Swap #empty? with #blank? and add tests#10045
Merged
Conversation
The commit that was un-reverted was problematic because of a `NoMethodError` when calling `empty?` on `nil` here:
```ruby
validates :acr_values, presence: true, if: ->(form) { form.vtr.empty? }
```
This commit replaces `#empty?` with `#blank?` which will work on nil. Additionally the `#parse_vtr` method was modified to consistently return `nil` if either a `vtr` param is not provided or the `vtr` param is not enabled.
Tests were added to cover this case.
[skip changelog]
mitchellhenke
approved these changes
Feb 6, 2024
zachmargolis
approved these changes
Feb 6, 2024
theabrad
approved these changes
Feb 6, 2024
solipet
approved these changes
Feb 6, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit on here that was un-reverted was problematic because of a
NoMethodErrorwhen callingempty?onnilhere:This commit replaces
#empty?with#blank?which will work on nil. Additionally the#parse_vtrmethod was modified to consistently returnnilif either avtrparam is not provided or thevtrparam is not enabled.Tests were added to cover this case.