LG-12070: Maintain incoming request for concurrent session logout#10040
Merged
LG-12070: Maintain incoming request for concurrent session logout#10040
Conversation
aduth
commented
Feb 6, 2024
aduth
commented
Feb 6, 2024
Contributor
Author
There was a problem hiding this comment.
This link_identity code wasn't strictly necessary so was removed to avoid excessive duplication in the new, similar test cases being added.
mdiarra3
approved these changes
Feb 6, 2024
mitchellhenke
approved these changes
Feb 6, 2024
changelog: Bug Fixes, Concurrent Session, Maintain authentication request when enforcing concurrent session limit
9ab88cb to
5be7d4f
Compare
zachmargolis
approved these changes
Feb 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12070
Related issue: #9407
🛠 Summary of changes
Updates OIDC and SAML controllers to set redirect URL ahead of concurrent session logout, to repeat the authentication request as redirect destination for the logout. This resolves an issue where authentication request details would otherwise be lost during the concurrent session logout.
The solution here is essentially the same as in LG-11777 (#9842), except applied to the authentication endpoints in addition to the logout endpoints handled there.
📜 Testing Plan
Prerequisite: Have both OIDC and SAML sample applications running separate from the IdP