Merged
Conversation
* Add failing test * Change component so test passes * Add tests for selfie quality/liveness * Add failing test for failed selfie * Make tests pass * Add heading text * Draft in selfie field error * Pass isFailedSelfie through from response * Remove unnessecary error message and routing * Add in line error text * Send correct errors when selfie fails * Fix name of error * Return correct errors for selfie fail * Hide subheading when isFailedSelfie * Show correct error messages * Fix todo comment so lint passes * Fix formating in yaml file * Change heading text to be correct * Fix test to find correct heading * changelog: User-Facing Improvements, In-person proofing, add frontend error messages for facematach fail scenario * Fix spec to look for new fields * Edit file and add test to reflect match fail * Add missing error field keys * Fix error message count in test * Receive the selfie failure from the BE * Remove comment note * Add comment to clarify test differences * Remove duplicate text * Fix comments * Make uppercasing match the rest of the codebase * Remove incorrect comments about tests
…#10121) * LG-12266: Stop reading from sp_session[:phishing_resistant_requested] In a previous commit the `resolved_authn_context_result` was introduced to return a `Vot::Parser::Result` object that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in the `sp_session` that serve this purpose including the `phishing_resistant_requested` key. This commit replaces places where the `sp_session[:phishing_resistant_requested]` value is read with new reads to the `resolved_authn_context_result`. [skip changelog] * fix how_to_verify_spec * fix in_person_opt_in_ipp_spec.rb
* Fix a 50/50 issue in the IALMax code We introduced a change (ref: https://github.com/18F/identity-idp/pull/10095/files) that started storing the IALMAX ACR value when the IAL1 ACR value is sent with the minimum authn context comparison. Prior to this change the ACR value in the session would be IAL1. That commit and later commits introduced code that expected that ACR value to be IALMAX when an IALMAX request was made. That led to issues when an IALMAX request was made with the old code that stored the IAL1 value. Specifically issues occurred in the SAML IDP controller when prompting to user to unlock their PII. This commit makes the code aware of the old approach as well as the new one and handling both. [skip changelog]
zachmargolis
approved these changes
Feb 22, 2024
jmhooper
added a commit
that referenced
this pull request
Feb 22, 2024
Revert "Merge pull request #10143 from 18F/stages/rc-2024-02-22-patch-1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes