Improve compatibility/precision for badge styles#445
Merged
Conversation
aduth
added
the
breaking change
zachmargolis
approved these changes
May 7, 2024
aduth
force-pushed
the
aduth-badge-icon-margin
branch
from
4a0875a to
042313f
Compare
Contributor
Author
|
I've been sitting on this in case I wanted to ship a minor release before the next major release, since it included a breaking change. Instead, I'm just going to keep the deprecation for now and address the specific fix, so it's not a breaking change. I'll create a separate pull request closer to the next major release with removals for those deprecations. |
aduth
removed
the
breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Iterates on styles introduced in #442 targeting the badge icon.
The IdP has a novel implementation of icon component which does not render markup as an
<svg />element, but does implement the equivalent as with theusa-iconclass. Since it would be preferable (more precise) to implement the class selector vs. an element selector, this improves compatibility as well as improving the general implementation.As part of the changes here, I dropped the selector which was deprecated as part of the work in #442, with the expectation this can be included in the next major release.
A patch release is not planned, and a temporary workaround will be added to the IdP instead.
📜 Testing Plan
Repeat testing plan from #442.
👀 Screenshots
There is not expected to be any visual impact of these changes, to be validated by the visual regression specs.