Skip to content

Run regression spec against preview site #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
May 2, 2023
Merged

Run regression spec against preview site #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee9021
Run regression spec against preview site
aduth May 1, 2023
ad24970
Strip baseurl from code example markup
aduth May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
### New Features

- Add support for SASS package entrypoints to limit or control loading of styles, [similar to USWDS components](https://designsystem.digital.gov/components/packages/). Available packages are `packages/required`, `packages/global`, `packages/components`, and `packages/utilities`.
- The [Side Navigation component](https://design.login.gov/components/side-navigation/) is now documented and includes updated and improved styling. While this should not require any markup changes, you should validate that the updated styling does not conflict with any product-specific styles for side navigation.
- The Side Navigation component is now documented and includes updated and improved styling. While this should not require any markup changes, you should validate that the updated styling does not conflict with any product-specific styles for side navigation.

### Bug Fixes

Expand Down Expand Up @@ -221,7 +221,7 @@
- Link hover and active colors are now distinct.
- Before: Hover and active colors are both `primary-darker`.
- After: Hover is `primary-dark`, and active is `primary-darker`.
- Improved support for "Unstyled" button variant ([see documentation](https://design.login.gov/components/buttons/))
- Improved support for "Unstyled" button variant
- Add three new button variants to control width:
- `usa-button--wide` displays a button at a wider (minimum) width at larger viewport displays.
- `usa-button--flexible-width` displays a button at flexible width regardless of viewport size, and overrides default mobile appearance of full-width buttons.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Since the Login.gov Design System is based upon the [U.S. Web Design System (USW

- Where possible, use [the available Sass theme variables](https://designsystem.digital.gov/documentation/developers/#customization-theming-and-tokens) to customize the appearance of components. These are configured under `src/scss/uswds-theme`. We only include the customized variables, to improve visibility of where differences are expected. Refer to the [USWDS theme variables source](https://github.com/uswds/uswds/tree/develop/src/stylesheets/theme) for the full set of configuration values.
- To limit side-effects and to clarify where styles are extended, customized USWDS styles should follow as close to the file location and CSS selector as possible. For example, if USWDS defines a selector `.usa-header` in `packages/usa-header` which defines a style `background` that we want to override, the style should be located at an identically-named selector in `src/scss/packages/_usa-header.scss` in this project.
- Prefer color and size tokens when possible. Never use hard-coded hex colors. Instead, use the `color` SCSS function with a [color token](https://design.login.gov/utilities/color/) as its argument.
- Prefer color and size tokens when possible. Never use hard-coded hex colors. Instead, use the `color` SCSS function with a [color token](https://designsystem.digital.gov/design-tokens/color/theme-tokens/) as its argument.

## Public domain

Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/helpers/code-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

<div markdown="1">
```html
{{ include.code | strip | replace_regex: '\s?data-test(?:="[^\s"]+")', '' }}
{{ include.code | replace: site.baseurl, '' | strip | replace_regex: '\s?data-test(?:="[^\s"]+")', '' }}
```
</div>
3 changes: 2 additions & 1 deletion test/screenshot.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const { getURLsFromSitemap } = require('./support/sitemap');
const { writeFile, mkdir } = fsPromises;

const LOCAL_HOST = `http://localhost:${process.env.JEST_PORT}`;
const REMOTE_HOST = 'https://design.login.gov';
const REMOTE_HOST =
'https://federalist-340d8801-aa16-4df5-ad22-b1e3e731098e.sites.pages.cloud.gov/site/18f/identity-design-system';
Comment on lines +13 to +14
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of trying to have this do a git checkout main or something instead of continuing to rely on federalist? My expectation is that by shutting down design.login.gov we'd remove everything published?

Copy link
Copy Markdown
Contributor Author

@aduth aduth May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the near term, I'm expecting we'll continue to use Federalist to be able to use the branch preview functionality, even if the main https://design.login.gov site will start to show a 404 (which, per #333 (comment), is still going to be hosted by Federalist).

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

const DIFF_DIRECTORY = join(__dirname, '../tmp/results/screenshot-diff');

async function stubAnimations() {
Expand Down