Merged
Conversation
Bumps [uswds](https://github.com/uswds/uswds) from 2.13.2 to 2.13.3. - [Release notes](https://github.com/uswds/uswds/releases) - [Commits](uswds/uswds@v2.13.2...v2.13.3) --- updated-dependencies: - dependency-name: uswds dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
type: dependencies
Contributor
|
From release notes:
We should be careful about the impact of this, since if we're not using the same exact version for shared dependencies, we'll likely be bundling two versions of the package. I can immediately see a couple potential conflicts:
Action items:
|
To make sure we're always sharing the same version as used transitively through uswds
So that it's clearer what version of USWDS we actually use
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Apr 12, 2022
**Why**: - Because polyfills are intended to be confined to the polyfill package (#6060) - So that it's not included in modern browsers (#6068, -0.9kb gzipped) - To reduce surface area of dependencies shared with USWDS (related to 18F/identity-design-system#312 (comment)) changelog: Internal, Optimization, Reduce size of JavaScript for modern browsers
Contributor
|
Visual regression failure is expected due to version number on home page:
|
aduth
approved these changes
Apr 13, 2022
aduth
added a commit
to 18F/identity-idp
that referenced
this pull request
Apr 13, 2022
**Why**: - Because polyfills are intended to be confined to the polyfill package (#6060) - So that it's not included in modern browsers (#6068, -0.9kb gzipped) - To reduce surface area of dependencies shared with USWDS (related to 18F/identity-design-system#312 (comment)) changelog: Internal, Optimization, Reduce size of JavaScript for modern browsers
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps uswds from 2.13.2 to 2.13.3.
Release notes
Sourced from uswds's releases.
Commits
974f976Merge pull request #4619 from uswds/release-2.13.380e90c5Create uswds-2.13.3-zip-hash.txtef87a9c2.13.3b546756Revert version and security hash to prep for re-output54da400Update references to 2.13.30952fe6Create uswds-2.13.3-zip-hash.txta503ef02.13.3641a6edUpdatemochato resolve minimist vulnerabilitycfee857Merge pull request #4620 from uswds/develop8349ad2Merge pull request #4618 from uswds/dependabot/npm_and_yarn/moment-2.29.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)