Skip to content

Prepare Release 6.4.2#314

Merged
SammySteiner merged 4 commits intomainfrom
release-6-4-2
May 16, 2022
Merged

Prepare Release 6.4.2#314
SammySteiner merged 4 commits intomainfrom
release-6-4-2

Conversation

@SammySteiner
Copy link
Contributor

Following release process: https://github.com/18F/identity-style-guide#releases

Changelog:

6.4.2

Dependencies

  • Update USWDS from v2.13.2 to 2.13.3. (#312)

Improvements

  • Add styles and markdown content for selected and disabled radios and checkboxes. (#313)

"requires": true,
"packages": {
"": {
"name": "identity-style-guide",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that your version of npm is up to date? I think it would not be expected that this line is removed, and I think I've seen it only in older versions of npm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on npm v7.18.1, and node v16.4.2.
Should I update and publish again or do I need to delete the branch and start again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to publish again. I think if you update npm, then run npm install on this branch, you should see a change that you just need to commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a lint for this, which is currently failing.

Error: There are uncommitted changes after running 'npm install'
make: *** [Makefile:28: validate-package-lock] Error 1

https://app.circleci.com/pipelines/github/18F/identity-style-guide/1025/workflows/b4fcfac5-1f14-47e0-8a69-4fb71cbd51bc/jobs/2760

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@SammySteiner SammySteiner merged commit 8de97a9 into main May 16, 2022
@SammySteiner SammySteiner deleted the release-6-4-2 branch May 16, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants