Skip to content

Remove classlist-polyfill from app scripts#6193

Merged
aduth merged 1 commit intomainfrom
aduth-rm-classlist-polyfill
Apr 13, 2022
Merged

Remove classlist-polyfill from app scripts#6193
aduth merged 1 commit intomainfrom
aduth-rm-classlist-polyfill

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 12, 2022

Why:

**Why**:

- Because polyfills are intended to be confined to the polyfill package (#6060)
- So that it's not included in modern browsers (#6068, -0.9kb gzipped)
- To reduce surface area of dependencies shared with USWDS (related to 18F/identity-design-system#312 (comment))

changelog: Internal, Optimization, Reduce size of JavaScript for modern browsers
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit b381b84 into main Apr 13, 2022
@aduth aduth deleted the aduth-rm-classlist-polyfill branch April 13, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants