v0.3.1 mumbai candidate#603
Merged
Merged
Conversation
Remove 'edit' from github CI workflow
Cover Bor Filters with testcases
The validator set json loaded from database will have an empty map. This change will recompute the validator map based on validator set.
Fix "Signer 0x... is not a part of the producer set at block xxxx"
…date defaults (#457) * updated simple.json and simple.hcl * added annotations for developer and grpc block * added toml tags and simple.toml file * added support for toml config files * updated simple files toml, hcl, json * added config.toml in builder/files and updated bor.service * add dumpconfig command in cli for exporting configs * update docs * updated .goreleaser.yml (POS-651) * changed --config to -config * added test config for tests and fixed lint errors * made fields of type big.int and time.Duration private, removed merge from dumpconfig, setting up default values to the Raw fields in dumpconfig, and fixed one lint error * fixed lint errors (strange) * lint fix * private no-more, using '-' in name tags to ignore * updated name tags, made c.configFile as a stringFlag (only one config file supported) and updated the merge logic in command.go -> Run() * fix: set method for big.Int flags, added a TODO * handeled bigInt and timeDuration type, bug fix in config_legacy, lint fix * updated flags, consistent across flags.go and config.go * fixed config test and updated test hcl, json config files * updated config legacy test * added test to check values of cmd flags, restructured Run in command.go, linter fix * fix linters * lint again * changed 2 flags and assert -> require * changed the 2 flags back * updated correct congig.toml path and made mainnet default * updated config.toml with new flags * added sample config (toml) file * removed sample-config.toml and added it in docs/config.md Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
* skip test in sealer test for ethhash consensus * add a todo and test skip reason
Add 'bor' user during package installation
fix fields transactionHash
Fix getTransactionReceiptsByBlock and TestGetTransactionReceiptsByBlock
add : statesync tx added to GetBlockTransactionCount rpc
qa to develop
…es, and packager update
Adding of 0.3.0 package changes, control file updates, postinst chang…
Codecov ReportBase: 56.92% // Head: 56.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## qa #603 +/- ##
==========================================
- Coverage 56.92% 56.76% -0.16%
==========================================
Files 598 607 +9
Lines 69243 70338 +1095
==========================================
+ Hits 39415 39928 +513
- Misses 26473 26994 +521
- Partials 3355 3416 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…rk/bor into arpit/v0.3.1-mumbai-candidate
In gorelease-cross 1.19+, dockerhub authentication will require docker logion action followed by mounting docker config file. See https://github.com/goreleaser/goreleaser-cross#github-actions.
manav2401
approved these changes
Dec 13, 2022
JekaMas
approved these changes
Dec 13, 2022
Contributor
|
Co we can remove codeowners according to the license? |
Contributor
Author
basically people who have contributed to the code shouldn't review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it