Skip to content

Cover Bor Filters with testcases#456

Merged
0xsharma merged 11 commits into
developfrom
shivam/pos-636
Jul 22, 2022
Merged

Cover Bor Filters with testcases#456
0xsharma merged 11 commits into
developfrom
shivam/pos-636

Conversation

@0xsharma
Copy link
Copy Markdown
Member

The PR contains the following changes :

  • Workaround to create state-sync tx manually for testcases.
  • Func TestBorFilters() : test filters for bor-transactions.
  • Some miner changes with sprint size. Sprint size will be determined from the genesis where as it was hardcoded to 64 before.

Link to Jira Task.

Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #456 (9aad8bf) into develop (c446937) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #456      +/-   ##
===========================================
- Coverage    56.30%   56.23%   -0.07%     
===========================================
  Files          603      600       -3     
  Lines        69529    69506      -23     
===========================================
- Hits         39149    39090      -59     
- Misses       27012    27032      +20     
- Partials      3368     3384      +16     
Impacted Files Coverage Δ
params/config.go 32.12% <ø> (ø)
eth/filters/bor_filter.go 66.66% <100.00%> (+66.66%) ⬆️
accounts/keystore/watch.go 90.69% <0.00%> (-9.31%) ⬇️
node/defaults.go 24.13% <0.00%> (-6.90%) ⬇️
rpc/server.go 72.50% <0.00%> (-5.00%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-3.65%) ⬇️
les/distributor.go 79.68% <0.00%> (-3.13%) ⬇️
p2p/enode/iter.go 88.34% <0.00%> (-2.92%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-2.90%) ⬇️
core/rawdb/chain_iterator.go 58.38% <0.00%> (-2.49%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c446937...9aad8bf. Read the comment docs.

Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go
Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go Outdated
Comment thread eth/filters/bor_filter_test.go
Comment thread eth/filters/bor_filter_test.go
Comment thread eth/filters/test_backend.go
@JekaMas
Copy link
Copy Markdown
Contributor

JekaMas commented Jul 20, 2022

@0xsharma Could you fix the CI?

@0xsharma 0xsharma merged commit f184772 into develop Jul 22, 2022
@0xsharma 0xsharma deleted the shivam/pos-636 branch July 22, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants