Skip to content

consensus/ethhash: skip TestRemoteMultiNotifyFull in sealer test#470

Merged
manav2401 merged 4 commits into
developfrom
manav/skip-testcase
Jul 27, 2022
Merged

consensus/ethhash: skip TestRemoteMultiNotifyFull in sealer test#470
manav2401 merged 4 commits into
developfrom
manav/skip-testcase

Conversation

@manav2401
Copy link
Copy Markdown
Member

@manav2401 manav2401 commented Jul 26, 2022

This PR skips one of the tests named TestRemoteMultiNotifyFull in the consensus/ethhash/sealer_test.go package. It is not a deterministic test and hence is one of primary cause of the failing CI in recent PRs. As we aren't dependent on the ethhash consensus, we can disable it for the time being. Later, according to bandwidth, we can identify the reasons and make it deterministic. A task for the same can be found here.

@manav2401 manav2401 requested a review from a team July 26, 2022 19:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #470 (a01d5e3) into develop (9dcc993) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #470      +/-   ##
===========================================
- Coverage    56.25%   56.21%   -0.05%     
===========================================
  Files          606      606              
  Lines        69846    69846              
===========================================
- Hits         39294    39262      -32     
- Misses       27169    27183      +14     
- Partials      3383     3401      +18     
Impacted Files Coverage Δ
rlp/raw.go 79.37% <0.00%> (-5.63%) ⬇️
rpc/server.go 72.50% <0.00%> (-5.00%) ⬇️
core/state/trie_prefetcher.go 76.33% <0.00%> (-3.82%) ⬇️
core/rawdb/chain_iterator.go 58.38% <0.00%> (-2.49%) ⬇️
les/costtracker.go 62.43% <0.00%> (-1.59%) ⬇️
trie/proof.go 74.29% <0.00%> (-1.41%) ⬇️
consensus/ethash/algorithm.go 92.76% <0.00%> (-1.32%) ⬇️
les/odr.go 89.02% <0.00%> (-1.22%) ⬇️
miner/worker.go 71.32% <0.00%> (-1.12%) ⬇️
p2p/simulations/mocker.go 32.22% <0.00%> (-1.12%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcc993...a01d5e3. Read the comment docs.

Comment thread consensus/ethash/sealer_test.go Outdated
@manav2401 manav2401 merged commit 6e8428b into develop Jul 27, 2022
@manav2401 manav2401 deleted the manav/skip-testcase branch July 27, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants