consensus/ethhash: skip TestRemoteMultiNotifyFull in sealer test#470
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #470 +/- ##
===========================================
- Coverage 56.25% 56.21% -0.05%
===========================================
Files 606 606
Lines 69846 69846
===========================================
- Hits 39294 39262 -32
- Misses 27169 27183 +14
- Partials 3383 3401 +18
Continue to review full report at Codecov.
|
pratikspatil024
approved these changes
Jul 27, 2022
JekaMas
approved these changes
Jul 27, 2022
JekaMas
reviewed
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips one of the tests named
TestRemoteMultiNotifyFullin theconsensus/ethhash/sealer_test.gopackage. It is not a deterministic test and hence is one of primary cause of the failing CI in recent PRs. As we aren't dependent on the ethhash consensus, we can disable it for the time being. Later, according to bandwidth, we can identify the reasons and make it deterministic. A task for the same can be found here.