Add meson build system support #525
Conversation
Doxyfile.in
Outdated
There was a problem hiding this comment.
We already have a Doxyfile in the Zydis repository. Can we reuse this here? It seems that we are just using the default in Zycore. Optimally we'd make it consistent between both repos. If you can think of a way to reuse the existing Doxyfile here, please feel free to also add one based on the Zydis Doxyfile to Zycore.
There was a problem hiding this comment.
The existing Doxyfile needs to be parsed by a simple CMake function, and thus we can't add things like @DEFINES@, "quoted strings" and feature detection.
Another reason it could not be unified is that there are some minor differences between the repo (e.g. what macros to or not to expand, should add external includes or not).
I made it much simpler in 7272cde. It's now only the diffs with the default config.
There was a problem hiding this comment.
Thank you, that looks a lot more managable! Doxygen allows including another config as a basis via @INCLUDE = config_file_name. Can we perhaps use this to further deduplicate? I think I'd also prefer if we could rename Doxygen.in to Doxygen.meson.in to communicate the purpose of the extra file more clearly.
There was a problem hiding this comment.
Done, but I think this might bring some confusion, especially when someone uses in-tree build. (however, rare to see these days, so we could ignore that scenario.)
mochaaP
force-pushed
the
master
branch
2 times, most recently
from
5065520
to
862adb0
Compare
mochaaP
force-pushed
the
master
branch
4 times, most recently
from
72df9d2
to
6a383f5
Compare
|
Should be ready. |
Requires zyantific/zycore-c#75.
Should've reached feature parity with CMake. Please let me know if I missed anything.