Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson build system support #75

Merged
merged 17 commits into from
Sep 19, 2024
Merged

Add meson build system support #75

merged 17 commits into from
Sep 19, 2024

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Sep 13, 2024

No description provided.

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 13, 2024

I plan to add this to Zydis soon. If this is acceptable, I will start working on it!

@athre0z
Copy link
Member

athre0z commented Sep 13, 2024

Hey and thank you for the PR! :)

I'm afraid that having a second build system may be quite a bit of a maintenance burden in the long run. I personally also don't have any experience with Meson at all, and to my knowledge neither does @flobernd. The only way that I see us accepting this would be if you were to volunteer to maintain it and help out whenever there are issues with it. Would that be a responsibility that you'd be willing to take?

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 13, 2024

Yes! I currently use this in my downstream project, and I'm patching Zydis to support my usage (it was a burden). I'd like to take this responsibility.

@mochaaP mochaaP force-pushed the master branch 3 times, most recently from 02afd6b to b173824 Compare September 14, 2024 10:58
@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 17, 2024

Please re-run the CI tasks. GitHub Actions had an outage earlier this day.

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 19, 2024

Working on windows support for the meson CI. Should I also add a MinGW-w64 gcc test for meson?

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 19, 2024

cc @athre0z for 7556690

@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 19, 2024

All CI tests are passing 😁

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for all the work on that! :)

@athre0z athre0z merged commit 38d4f02 into zyantific:master Sep 19, 2024
48 checks passed
@mochaaP
Copy link
Contributor Author

mochaaP commented Sep 19, 2024

great, i can start refining the zydis one :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants