Skip to content

accountsReducer [nfc]: Followups on handling restart events #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisbobbe merged 3 commits into from
Jun 11, 2021
Merged

accountsReducer [nfc]: Followups on handling restart events #4794

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c64a85
accounts [nfc]: Use named constant for case on event.type.
gnprice Jun 11, 2021
6e869c1
accounts [nfc]: Use an early return to simplify logic slightly.
gnprice Jun 11, 2021
807f6c1
accounts [nfc]: Point upgrade-refresh TODO at issue newly filed.
gnprice Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions src/account/accountsReducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
LOGOUT,
ACCOUNT_REMOVE,
} from '../actionConstants';

import { EventTypes } from '../api/eventTypes';
import type { AccountsState, Identity, Action } from '../types';
import { NULL_ARRAY } from '../nullObjects';
import { ZulipVersion } from '../utils/zulipVersion';
Expand Down Expand Up @@ -115,24 +115,22 @@ export default (state: AccountsState = initialState, action: Action): AccountsSt
case EVENT: {
const { event } = action;
switch (event.type) {
case 'restart': {
case EventTypes.restart: {
const { zulip_feature_level, zulip_version } = event;
return zulip_feature_level !== undefined && zulip_version !== undefined
? [
{
...state[0],

// TODO (?): Detect if these are different from the values
// we had before, so we know it's an upgrade, not just a
// restart. Then, implement logic like "be sure to refetch
// from scratch within N hours" (to avoid thundering
// herding the server).
zulipVersion: new ZulipVersion(zulip_version),
zulipFeatureLevel: zulip_feature_level,
},
...state.slice(1),
]
: state;
if (zulip_feature_level === undefined || zulip_version === undefined) {
return state;
}

// TODO: Detect if the feature level has changed, indicating an upgrade;
// if so, trigger a full refetch of server data. See #4793.
return [
{
...state[0],
zulipVersion: new ZulipVersion(zulip_version),
zulipFeatureLevel: zulip_feature_level,
},
...state.slice(1),
];
}
default:
return state;
Expand Down