accountsReducer [nfc]: Followups on handling restart events#4794
Merged
chrisbobbe merged 3 commits intozulip:masterfrom Jun 11, 2021
Merged
accountsReducer [nfc]: Followups on handling restart events#4794chrisbobbe merged 3 commits intozulip:masterfrom
chrisbobbe merged 3 commits intozulip:masterfrom
Conversation
This helps make it clear where this particular string value is coming from.
Just as the early-return pattern usually does, this puts the exceptional case's condition and body together, and lets the happy normal case read straight vertically down the screen. Here, it also eliminates a ternary operator.
And tighten the comment here, now that the details live there.
Contributor
|
LGTM, thanks! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some small tweaks in the handy new
restart-event implementation added in #4707.