action sheets [nfc]: Factor out makeButtonCallback.#4566
Merged
WesleyAC merged 1 commit intozulip:masterfrom Mar 27, 2021
Merged
action sheets [nfc]: Factor out makeButtonCallback.#4566WesleyAC merged 1 commit intozulip:masterfrom
WesleyAC merged 1 commit intozulip:masterfrom
Conversation
This deduplicates a bit of code, notably the try/catch and the alert on error.
WesleyAC
approved these changes
Mar 27, 2021
Contributor
WesleyAC
left a comment
WesleyAC
left a comment
There was a problem hiding this comment.
Oh, nice! I didn't think to pass in the entire Args object when I was writing this, that makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deduplicates a bit of code, notably the try/catch and the alert on error.
A small followup to #4541 (review) .