test: Use pumpAndSettle to await overscroll animation #1833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a PR to port the new Android 12 overscroll effect. During this process, I encountered a test that was failing when it should have passed.
The root cause of the failure is that the test asserts a widget's absolute position immediately after a scroll gesture, without waiting for the overscroll physics animation to complete. A single pump() is insufficient for the animation to settle.
The solution is to replace the
pump()call withpumpAndSettle(). This ensures that all animations are finished before the test makes its assertions, making the test reliable.For more technical context on this new overscroll animation, please refer to the PR at:
flutter/flutter#173849