Skip to content

test: Use pumpAndSettle to await overscroll animation #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

test: Use pumpAndSettle to await overscroll animation #1833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/widgets/emoji_reaction_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ void main() {

// Scroll to the very bottom of the list with a large offset.
await tester.drag(scrollViewFinder, Offset(0, -500));
await tester.pump();
await tester.pumpAndSettle(); // let overscroll finish
// The top edge of the list entries is out of view;
// the bottom is padded by 8px, the minimum padding, from the bottom
// edge of the scroll view.
Expand All @@ -637,7 +637,7 @@ void main() {

// Scroll to the very bottom of the list with a large offset.
await tester.drag(scrollViewFinder, Offset(0, -500));
await tester.pump();
await tester.pumpAndSettle(); // let overscroll finish
// The top edge of the list entries is out of view;
// the bottom edge is padded by 10px from the bottom edge of the scroll
// view, because the view bottom padding is larger than the minimum 8px.
Expand Down