BrowserView: Rebased and cleaned up #1018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
View extends the BrowserView class in the main process and provides and interface similar to webview. Other functions can be added later when required.
Adds ViewManager class which makes it easier to create, manage and delete views. Also, created some basic listeners which will be required later.
Removes all instances of webview from main.ts and adds an initial working instance of BrowserView.
Implements logic for updating badgeCount to show message count in sidebar.
Removes tooltips that we show for orgs and settings, as these tooltips are no more visible over the BrowserViews, so there is no use of keeping them. Instead, uses title property of HTMLElements, which can be displayed over BrowserViews.
Destroys all views to recreate them later when app is reloaded. Also, set lastActiveIndex to 0 when a tab is removed.
Adds a refresh function which refreshes view every 200 ms, and shows it only if the view DOM content is loaded. Also, gets rid of buggy browser view switching which we were facing earlier.
Removes the heavy setInterval which we were using earlier to prevent heavy CPU Usage. The main reason we were using a setInterval earlier was because view switching was buggy. This commit fixes that.
|
Heads up @manavmehta, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Builds upon #831 which was built upon #793
You have tested this PR on:
** Tasks **
** Temporarily Reverted PR's and commits:**
Commits reverted:
PR's reverted: