crashes in MacOS #1016

PhotoNomad0 · 2020-08-12T13:57:18Z

Describe the bug
A few of our MacOS Catalina users that are running the Zulip desktop are seeing frequent crashes in the app. But only the MacOS users. After a while the window just has the toolbar with the rest of the window just grey (screenshot below). When I click on the reload icon, the desktop app closes.

To Reproduce
Just open the app and leave it running. Notifications are turned on.

Expected behavior
That the app not crash and work as before.

Screenshots

Desktop (please complete the following information):

Operating System:
macOS 10.15.5 and 10.15.6
Zulip Desktop Version:
5.4.0

Additional context
Seems to happen more frequently when usage on unfoldingword.zulipchat.com is heaviest.

manavmehta · 2020-08-12T17:37:10Z

For the record: Upstream issue - electron/24920

Thomas-lhuillier · 2020-09-15T09:53:45Z

Not sure it's very helpful but here is the console error raised when this bug occurs.

timabbott · 2020-09-16T00:16:37Z

@Thomas-lhuillier thanks, that's likely quite helpful.

Can you confirm you're seeing this with the latest 5.4.3 release?

timabbott · 2020-09-16T00:17:21Z

(I believe this was likely fixed in 5.4.2).

Thomas-lhuillier · 2020-09-16T07:56:23Z

Unfortunately I experience this bug on both v5.4.2 and v5.4.3.

One thing I noted: it seems to happen when receiving private messages.

PhotoNomad0 · 2020-09-16T20:06:52Z

I am also still seeing in v5.4.3. Forgot that this was an electron app. I do see the same error message in the screenshot above.

sipshowpeers · 2020-09-17T15:18:09Z

I am also still seeing this in 5.4.3, MacOS 10.15.6.
I can consistently reproduce this when I am private messaged by one particular person in our organization.
This is on a self-hosted Zulip server.
I would like to help but I don't know what information I can provide (and whether it's safe to share publicly!)

timabbott · 2020-09-17T23:36:54Z

If you can capture the exception from the developer tools (available in the app's menus), that'd be very helpful.

sipshowpeers · 2020-09-18T13:30:24Z

I hope this is helpful! Please let me know if there's further information I can share.

This is immediately after receiving a private message causing my screen to go gray (or grey):

electron/js2c/renderer_init.js:142 Uncaught TypeError: Cannot read property 'forEach' of undefined
    at dispatchEvent (electron/js2c/renderer_init.js:142)
    at EventEmitter.<anonymous> (electron/js2c/renderer_init.js:142)
    at EventEmitter.emit (events.js:223)
    at Object.onMessage (electron/js2c/renderer_init.js:114)
dispatchEvent @ electron/js2c/renderer_init.js:142
(anonymous) @ electron/js2c/renderer_init.js:142
emit @ events.js:223
onMessage @ electron/js2c/renderer_init.js:114

It appears to be the same that @Thomas-lhuillier showed. Is there more info I can share?

timabbott · 2020-09-22T22:56:11Z

@manavmehta @akashnimare can you try to investigate this exception?

timabbott · 2020-09-22T22:56:52Z

I'm guessing this is a notifications library issue is some sort, and we should probably start with doing a build with Electron 10 to see if it's resolved upstream like the previous iteration was.

leather-s · 2020-10-07T21:31:22Z

Any action on this? I too have been experiencing this for the last month. I dont even use the desktop app anymore because it crashes so frequently.

PhotoNomad0 · 2020-10-08T19:22:40Z

The best solution we have found is for Mac users to install the older v5.2.0 of desktop app and turn off auto updates.

kannan4k · 2020-10-20T14:24:53Z

I've faced the same problem with v5.2.0 & v5.3.0.
Here is the error message

MaxXxaM · 2020-11-13T12:38:34Z

The same issue with v5.4.3 after update MacOS Big Sur. It happens at different times, usually after the application has been minimized.

tourvi · 2020-11-13T16:57:59Z

Same here. Just upgraded to Big Sur, and just started getting this problem. v5.4.3. Usually happens when receiving a private message.

manavmehta · 2020-11-13T18:56:46Z

@akashnimare Sorry for being AFK for too long. I don't think it is a macOS bug now. As Big Sur is a big change, they must have tested the reported bugs, which again, 'might' have included the cause of this. Nor does the error pointed out by @sipshowpeers seem to be 'directly' coming from our codebase but some electron-ish library/API we use.

manavmehta · 2020-11-13T18:58:39Z

Update: I am one of the people who saw this bug very very rarely.
Just witnessed this on Big Sur - Prod always. Never Dev.

manavmehta · 2020-11-13T20:09:42Z

I believe this error is originating from here - WebView.
One solution I can think of is completing #1018

There have been recent discussions on upstream thread.

hankhero · 2020-11-17T08:33:23Z

We have several users in our organisation that experience this problem ONLY after updatating to MacOs Big Sur.

frammling · 2020-11-17T08:38:16Z

We have several users in our organisation that experience this problem ONLY after updatating to MacOs Big Sur.

Same issue after updating to MacOs Big Sur. Zulip version 5.4.3

andersk · 2020-11-18T07:36:37Z

Can someone figure out, either via a debugger or by patching console.log statements into Electron, what eventKey is when this WEB_VIEW_EVENTS[eventKey].forEach expression is undefined?

I have a wild guess… This would explain why that TypeError would be triggered by the render process crashing, but not why the render process crashes in the first place.

l4ty4k · 2020-11-19T07:27:49Z

Same here. I only started experiencing this bug after updating to Big Sur.

andersk · 2020-11-20T19:33:58Z

We’ve received a trace from a user that seemingly matches this to CharlieHess/node-mac-notifier#33.

parallelo3301 · 2020-11-26T18:28:06Z

Adding another one. Like @timabbott & @andersk noticed, this may definitely be a problem with the notifications. The app crashes for my colleagues when I send them a PM.

This line may be a lead:
Granted permissions request for notifications from null

I also tried to navigate them to Settings -> Notifications -> Send test notification and the app crashed then.

luckow · 2020-11-27T10:39:00Z

I get the same issue with grey-screen-of-death multiple times a day - but only after upgrading to OSX Big Sur. v5.4.3 of the Desktop app.

Seems to be happing randomly - sometimes multiple times within a minute. Sometimes when I write a message, sometimes it just happens when the app has been out-of-focus for some time. Other times hours go by without problems.

When I press the refresh button it works again for a while - until the next "crash". Really annoying and makes the desktop app almost unusable for mig.

I'm cheering for you, hoping you'll figure it out soon! ;-)

GervaisdeM · 2020-11-27T12:54:10Z

I just thought I would chime in and say that this is happening to me also. I thought it might have been an issue with my under powered self hosted Zulip server, but then I found this thread. I have only two active users on my server. My logs are likely very lean. If there is something that you would like tested and have logs sent your way, let me know. I'm also on chat.zulip.org if that helps.

I have rolled back to 5.2.0 of the client for now. It seems to be stable.

Gambitboy · 2020-12-01T11:47:45Z

My entire team and I have been getting this crash on v5.4.3 and a few before, way before the Big Sur OSX update. Only happens on the macOS app, the browser version is fine. Crashes on every notification popup.

node-mac-notifier no longer builds on macOS with Electron 11 (error: no template named 'remove_cv_t' in namespace 'std'). It was previously implicated in crashes on macOS (zulip#1016). And we no longer have any macOS developers that seem to be maintaining this feature (e.g. zulip#1022 is stalled). Signed-off-by: Anders Kaseorg <[email protected]>

andersk · 2020-12-02T17:50:31Z

We believe this has been resolved by removing node-mac-notifier (#1046) in 5.5.0, just released. Can anyone confirm?

rhusar · 2020-12-02T17:53:09Z

@andersk I can confirm after couple of hours of using master branch that I no longer get the 'gray screen of death'. Thanks for the fix!

tourvi · 2020-12-02T18:15:44Z

Works for me, too, using v5.5.0

andersk · 2020-12-02T18:20:53Z

Great, thanks all. Closing as fixed. If anyone does see this again with v5.5.0, please let us know.

lukasztuszynski · 2020-12-03T10:50:17Z

Works for me as well (so far ;) )

Gambitboy · 2020-12-04T04:30:58Z

Can also confirm it works. Thanks guys.

luckow · 2020-12-04T07:30:36Z

Same for me. Has been working flawlessly since the upgrade to 5.5.0. 🚀 Much appreciated 🙏

rhusar · 2020-12-04T09:05:36Z

Just for the record, hopefully the grey screen wasn't just replaced by white screen I found in Zulip this morning after nightly suspend and morning resume. This time however it was solvable by #+R, so a different issue.

andersk · 2020-12-04T22:46:03Z

@rhusar Yeah, that’s almost certainly different. If it happens to you again, file a new issue and include any errors you might find in Tools → Toggle DevTools for Zulip App → Console and/or Tools → Toggle DevTools for Active Tab → Console.

kannan4k · 2020-12-08T13:12:35Z

Worked for me! Thank you folks 🎉

timabbott added the Priority: High label Sep 22, 2020

Gambitboy mentioned this issue Oct 30, 2020

Grey Screen upon editing message and other actions, freezing the webview electron/electron#24920

Closed

3 tasks

andersk mentioned this issue Nov 18, 2020

refactor: remove duplicate <webview> event list electron/electron#25697

Merged

3 tasks

andersk mentioned this issue Nov 24, 2020

Zulip desktop on MacOS Big Sur shows gray screen when new message arrives #1044

Closed

andersk mentioned this issue Dec 2, 2020

Remove macOS inline replies feature #1046

Merged

andersk mentioned this issue Dec 2, 2020

release: New release v5.5.0 #1047

Merged

andersk closed this as completed Dec 2, 2020

timabbott mentioned this issue Apr 9, 2021

zulip desktop application stops working after every message i receive and i have to refresh it zulip/zulip#16826

Closed

crashes in MacOS #1016

crashes in MacOS #1016

Comments

PhotoNomad0 commented Aug 12, 2020 • edited Loading

manavmehta commented Aug 12, 2020

Thomas-lhuillier commented Sep 15, 2020

timabbott commented Sep 16, 2020

timabbott commented Sep 16, 2020

Thomas-lhuillier commented Sep 16, 2020 • edited Loading

PhotoNomad0 commented Sep 16, 2020

sipshowpeers commented Sep 17, 2020

timabbott commented Sep 17, 2020

sipshowpeers commented Sep 18, 2020 • edited Loading

timabbott commented Sep 22, 2020

timabbott commented Sep 22, 2020

leather-s commented Oct 7, 2020

PhotoNomad0 commented Oct 8, 2020

kannan4k commented Oct 20, 2020

MaxXxaM commented Nov 13, 2020 • edited Loading

tourvi commented Nov 13, 2020

manavmehta commented Nov 13, 2020

manavmehta commented Nov 13, 2020 • edited Loading

manavmehta commented Nov 13, 2020 • edited Loading

hankhero commented Nov 17, 2020

frammling commented Nov 17, 2020 • edited Loading

andersk commented Nov 18, 2020 • edited Loading

l4ty4k commented Nov 19, 2020 • edited by andersk Loading

andersk commented Nov 20, 2020

parallelo3301 commented Nov 26, 2020

luckow commented Nov 27, 2020

GervaisdeM commented Nov 27, 2020

Gambitboy commented Dec 1, 2020 • edited Loading

andersk commented Dec 2, 2020

rhusar commented Dec 2, 2020

tourvi commented Dec 2, 2020

andersk commented Dec 2, 2020

lukasztuszynski commented Dec 3, 2020

Gambitboy commented Dec 4, 2020

luckow commented Dec 4, 2020

rhusar commented Dec 4, 2020

andersk commented Dec 4, 2020

kannan4k commented Dec 8, 2020

PhotoNomad0 commented Aug 12, 2020 •

edited

Loading

Thomas-lhuillier commented Sep 16, 2020 •

edited

Loading

sipshowpeers commented Sep 18, 2020 •

edited

Loading

MaxXxaM commented Nov 13, 2020 •

edited

Loading

manavmehta commented Nov 13, 2020 •

edited

Loading

manavmehta commented Nov 13, 2020 •

edited

Loading

frammling commented Nov 17, 2020 •

edited

Loading

andersk commented Nov 18, 2020 •

edited

Loading

l4ty4k commented Nov 19, 2020 •

edited by andersk

Loading

Gambitboy commented Dec 1, 2020 •

edited

Loading