Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore __static_attributes__ added in Python 3.13a6. #290

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Ignore __static_attributes__ added in Python 3.13a6. #290

merged 1 commit into from
Apr 12, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 12, 2024

Fixes #289.

@icemac icemac requested a review from dataflake April 12, 2024 05:45
@icemac icemac self-assigned this Apr 12, 2024
@icemac icemac mentioned this pull request Apr 12, 2024
Merged
1 task
dataflake
dataflake approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I tried to build zodbpickle on 3.13.0a6 yesterday and it failed due to that thing. I didn't even know what it meant or where to look.

@dataflake dataflake merged commit 57c073f into master Apr 12, 2024
46 checks passed
@dataflake dataflake deleted the fix-289__static_attributes__ branch April 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@dataflake dataflake dataflake approved these changes

Assignees

@icemac icemac

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaks on Python 3.13a6: InvalidInterface: Concrete attribute, __static_attributes__
3 participants
@icemac @tseaver @dataflake