-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Windows wheels on GHA. #84
Conversation
@tseaver I just added windows support for Python 3.13 and ran into |
Because we are emulating the Python stdlib function only for internal purposes, we do not want (nor are we allowed) to export it as a publically-linkable endpoing.
@tseaver Thank you for fixing this issue. I am on the problem in |
@icemac I just tried reproducing that error locally, including making a separate venv and installing the same way the GH workflow does (as much as I could): $ python3.13 -m venv /tmp/waaaaa
$ /tmp/waaaaa/bin/pip install --upgrade setuptools wheel
Collecting setuptools
...
Successfully installed setuptools-69.2.0 wheel-0.43.0
$ /tmp/waaaaa/bin/pip install -U --no-binary :all: coverage
Collecting coverage
Using cached coverage-7.4.4-cp313-cp313-linux_x86_64.whl
Installing collected packages: coverage
Successfully installed coverage-7.4.4
$ /tmp/waaaaa/bin/pip install --pre -e .[test]
Obtaining file:///home/tseaver/projects/Zope/ZODB/zodbpickle
Preparing metadata (setup.py) ... done
Requirement already satisfied: setuptools in /tmp/waaaaa/lib/python3.13/site-packages (from zodbpickle==3.3.dev0) (69.2.0)
Collecting zope.testrunner (from zodbpickle==3.3.dev0)
Using cached zope.testrunner-6.4-py3-none-any.whl.metadata (22 kB)
Collecting zope.exceptions (from zope.testrunner->zodbpickle==3.3.dev0)
Using cached zope.exceptions-5.0.1-py3-none-any.whl.metadata (8.4 kB)
Collecting zope.interface (from zope.testrunner->zodbpickle==3.3.dev0)
Using cached zope.interface-6.2-cp313-cp313-linux_x86_64.whl
Using cached zope.testrunner-6.4-py3-none-any.whl (231 kB)
Using cached zope.exceptions-5.0.1-py3-none-any.whl (19 kB)
Installing collected packages: zope.interface, zodbpickle, zope.exceptions, zope.testrunner
Running setup.py develop for zodbpickle
Successfully installed zodbpickle-3.3.dev0 zope.exceptions-5.0.1 zope.interface-6.2 zope.testrunner-6.4
$ /tmp/waaaaa/bin/python -m coverage run -p -m zope.testrunner --test-path=src
Running zope.testrunner.layer.UnitTests tests:
Set up zope.testrunner.layer.UnitTests in 0.000 seconds.
Ran 427 tests with 0 failures, 0 errors and 20 skipped in 3.739 seconds.
Tearing down left over layers:
Tear down zope.testrunner.layer.UnitTests in 0.000 seconds. Is there maybe a broken |
I get the same issues Michael saw on my local machine. |
@dataflake ah, I looked at zopefoundation/zope.interface#289 -- I'm still running Python 3.130a5. |
I merged the changes for |
Thank you for reviewing this PR. 😃 |
Needs:
__static_attributes__
added in Python 3.13a6. zope.interface#290 merged and released.