Soft Off (take 3) #2085
Merged
Soft Off (take 3) #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
enhancement
joelspadin
approved these changes
Dec 30, 2023
petejohanson
force-pushed
the
features/soft-off-take-3
branch
from
35bbe00 to
85f0d23
Compare
petejohanson
force-pushed
the
features/soft-off-take-3
branch
from
1ce6e05 to
0801377
Compare
51 tasks
petejohanson
force-pushed
the
features/soft-off-take-3
branch
from
0801377 to
b0ce505
Compare
joelspadin
reviewed
Jan 21, 2024
petejohanson
force-pushed
the
features/soft-off-take-3
branch
2 times, most recently
from
60ac8b0 to
ecac94d
Compare
joelspadin
reviewed
Jan 24, 2024
joelspadin
reviewed
Jan 27, 2024
petejohanson
force-pushed
the
features/soft-off-take-3
branch
2 times, most recently
from
6c2dc72 to
82dbe3c
Compare
joelspadin
reviewed
Jan 30, 2024
joelspadin
approved these changes
Jan 30, 2024
petejohanson
force-pushed
the
features/soft-off-take-3
branch
3 times, most recently
from
c3281e9 to
911ad68
Compare
|
@caksoylar Ok, I've pushed updated docs to cover the new sideband behavior kscan driver and how to use it with simple direct GPIO and for matrix integrated hardware combos. Would appreciate your feedback when you have a sec. |
caksoylar
reviewed
Feb 20, 2024
docs/docs/features/soft-off.md
Outdated
|
|
||
| - The `gpios` property should be a phandle-array with a fully defined GPIO pin and with the correct pull up/down and active high/low flags set. In the above example the soft on/off would be triggered by pulling the specified pin low, typically by pressing a switch that has the other leg connected to ground. | ||
|
|
||
| #### Soft Off Waker |
There was a problem hiding this comment.
I am having some trouble understanding: Is this still necessary if you follow the "Simple Direct Pin" section under sideband?
There was a problem hiding this comment.
So.. good question. Yes, but let me think if we could avoid it and just depend on the direct kscan itself to do the waking in that case.
There was a problem hiding this comment.
Ok, so did a little testing, and no, it isn't actually required in that case, you can directly use the small dedicated direct kscan as the soft off waker.... Let me think about how best to capture this in the docs.
There was a problem hiding this comment.
@caksoylar Ok, pushed docs tweaks and changed the ZMK Uno shield to reflect the updated recommended approach that adds the extra waker only when using the matrix integrated approach.
Closed
* Code style to avoid goto. * Enable pm.c compilation via dedicated Kconfig flag. * Comment wakeup trigger PM behavior.
* Remove the painful scanned behavior trigger for now, future enhancement will restore this high level functionality using kscan directly.
* Allow specifying direct kscan driver pins using gpio-key list as an alternative.
* Instead of gpio key behavior trigger, add new kscan driver that decorates/wraps a given kscan driver and will invoke basic system behavior assigned to a given row + column, without the need for keymap mapping in the matrix transform, bypassing keymaps entirely.
* Invoke output selection from the slider on the ZMK Uno via sideband behavior setup, to simplify keymap.
* Add a small sleep to allow other threads to send data for the endpoint clearing before sleep.
* Properly implement the PM hook needed for sideband behavior kscan device to have wakeup source enabled on it.
* Add dedicated init priority for the sideband kscan. * Refactor sideband code for clarity. * Tweaks to direct kscan for clarity. * Make sideband behavior row optional for brevity. * Allow overriding ZMK Uno sideband behaviors.
* Document new sideband behavior kscan driver for integrated soft-off support.
* Use the correct property for extra GPIOs to make active for the waker before going into soft off state. * Change header depth for easier navigation of the soft off feature page. Co-authored-by: Pablo Martínez <[email protected]>
* When adding a dedicated GPIO pin for soft off/on, use the direct kscan as the waker, instead of adding an additional node.
* Avoid overwriting random memory by using iterable section created by Zephyr PM.
* Add new flag to differentiate soft off on peripherals that is invoked by split GATT svc and dedicated additional ones tied to GPIO pin.
petejohanson
force-pushed
the
features/soft-off-take-3
branch
from
5de1c85 to
89f564d
Compare
caksoylar
reviewed
Mar 25, 2024
caksoylar
reviewed
Mar 25, 2024
petejohanson
force-pushed
the
features/soft-off-take-3
branch
from
e414937 to
be0ada2
Compare
caksoylar
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, after some good discussion with @joelspadin around the cursed "scanned behavior trigger" we've decided to pursue another route. This PR replaces #1942 and removes the scanned trigger, as well as fixing the last few review items there. Hoping this will be the one that finally wins. A follow up PR will add "side band kscan behavior triggers" so that the "matrix integrated soft off" is supported sanely.