Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): M60 keyboard use back button as power switch #1849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hyx0329
Copy link
Contributor

@hyx0329 hyx0329 commented Jun 25, 2023

M60 doesn't have a physical power switch. This pr makes it possible to fully power off the keyboard.

This may also improve keyboard power stability.

I've been using it for a month, so far so good. Pick it if anyone need this.

@hyx0329 hyx0329 force-pushed the m60-back-button-as-power-switch branch from 6f98274 to cd7f8fd Compare February 27, 2024 14:36
@hyx0329
Copy link
Contributor Author

hyx0329 commented Feb 27, 2024

rebased and updated, would like to merge and requesting review

@caksoylar caksoylar added the board PRs and issues related to boards. label Feb 27, 2024
@caksoylar
Copy link
Contributor

It looks like this is specific to m60 since it uses the specific button on the back, not the nrf52840_m2 board? If that's the case it looks like it should live in the shield folder, not the board.

@caksoylar
Copy link
Contributor

Also potential overlap with #2085.

@hyx0329 hyx0329 force-pushed the m60-back-button-as-power-switch branch from cd7f8fd to dc5a02f Compare February 28, 2024 06:44
@hyx0329
Copy link
Contributor Author

hyx0329 commented Feb 28, 2024

It looks like this is specific to m60

Yes it's m60 specific. Now I've moved everything m60-specific to the shields folder and updated the code to use zephyr's gpio api.

Also potential overlap with 2085

I don't think it's overlap with soft off as this is literally a built-in hardware switch to control SYSOFF on the PMU to disconnect battery.

From BQ24075 datasheet:

SYSOFF: System Enable Input. Connect SYSOFF high to turn off the FET connecting the battery to the system
output. When an adapter is connected, charging is also disabled. Connect SYSOFF low for normal operation.
SYSOFF is internally pulled up to VBAT through a large resistor (approximately 5 MΩ). Do not leave SYSOFF
unconnected to ensure proper operation.

@caksoylar caksoylar added shields PRs and issues related to shields and removed board PRs and issues related to boards. labels Feb 28, 2024
@hyx0329 hyx0329 force-pushed the m60-back-button-as-power-switch branch from dc5a02f to b7ae581 Compare February 7, 2025 06:00
@hyx0329 hyx0329 force-pushed the m60-back-button-as-power-switch branch from b7ae581 to f221af4 Compare February 7, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants