Skip to content

Conversation

@pinkforest
Copy link

@pinkforest pinkforest commented Jan 28, 2025

@tisonkun
Copy link

tisonkun commented Feb 2, 2025

cc @str4d

@tisonkun
Copy link

tisonkun commented Feb 2, 2025

This version bump blocks RustCrypto's elliptic-curve from upgrading to rand_core 0.9. Mainly because the public API directly expose rand_core's trait bound (Field::random).

@str4d
Copy link
Member

str4d commented Feb 23, 2025

Yep, I plan to coordinate with @tarcieri on this, because breaking releases of ff are very disruptive to a large crate ecosystem.

@tarcieri
Copy link
Contributor

@str4d a prerelease with this change would be helpful, if you could maybe make a branch for the breaking changes

@str4d
Copy link
Member

str4d commented Mar 9, 2025

I'm going to retarget this at a feature integration branch for the next breaking release, and cut a pre-release.

rust-toolchain Outdated
@@ -1 +1 @@
1.56.0
1.66.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insufficient to produce an MSRV bump. I will do this in a separate PR.

Copy link
Member

@str4d str4d Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, MSRV 1.66 is a false MSRV, because it is possible to pin to blake2b_simd 1.0.0 in order to avoid the constant_time_eq bumps (and these are only dev-dependencies anyway). There's no need to raise MSRV beyond what rand forces.

@str4d str4d changed the base branch from main to release-0.14.0 March 9, 2025 02:15
@str4d
Copy link
Member

str4d commented Mar 9, 2025

Rebased on release-0.14.0 to replace the incomplete MSRV bump in this PR, add the missing changelog update, and bring in the updated CI.

Copy link
Member

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e4bcf3c

@str4d str4d merged commit e93ada0 into zkcrypto:release-0.14.0 Mar 9, 2025
11 checks passed
@tarcieri tarcieri mentioned this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants