-
Notifications
You must be signed in to change notification settings - Fork 124
Bump rand to 0.9 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rand to 0.9 #122
Conversation
|
cc @str4d |
|
This version bump blocks RustCrypto's |
|
Yep, I plan to coordinate with @tarcieri on this, because breaking releases of ff are very disruptive to a large crate ecosystem. |
|
@str4d a prerelease with this change would be helpful, if you could maybe make a branch for the breaking changes |
|
I'm going to retarget this at a feature integration branch for the next breaking release, and cut a pre-release. |
rust-toolchain
Outdated
| @@ -1 +1 @@ | |||
| 1.56.0 | |||
| 1.66.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is insufficient to produce an MSRV bump. I will do this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, MSRV 1.66 is a false MSRV, because it is possible to pin to blake2b_simd 1.0.0 in order to avoid the constant_time_eq bumps (and these are only dev-dependencies anyway). There's no need to raise MSRV beyond what rand forces.
|
Rebased on |
str4d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e4bcf3c
https://github.com/rust-random/rand/releases/tag/0.9.0