Skip to content

sec1: upgrade to edition 2024; bump MSRV to 1.85 #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2025
Merged

sec1: upgrade to edition 2024; bump MSRV to 1.85 #1666

merged 2 commits into from
Feb 23, 2025

Conversation

@baloo
Copy link
Member

@baloo baloo commented Feb 23, 2025 •
edited
Loading

sec1 gets excluded from the workspace temporarily until we get elliptic-curve's edition bumped

@baloo baloo force-pushed the baloo/sec1/edition-2024 branch from 4ce2139 to 0f1354f Compare February 23, 2025 05:20
@baloo baloo mentioned this pull request Feb 23, 2025
Merged
@baloo baloo force-pushed the baloo/sec1/edition-2024 branch from 0f1354f to 38d5088 Compare February 23, 2025 05:32
@baloo baloo force-pushed the baloo/sec1/edition-2024 branch from 38d5088 to 2f3a890 Compare February 23, 2025 06:01
@tarcieri
Copy link
Member

tarcieri commented Feb 23, 2025

@baloo sidebar: const-oid would really help since we could probably do a release when it’s upgraded

@tarcieri tarcieri merged commit d4030f8 into RustCrypto:master Feb 23, 2025
165 checks passed
@baloo
Copy link
Member Author

baloo commented Feb 23, 2025

I actually don't know if we need to bump editions for const-oid, der, pkcs*, or spki.

The only reason I'm seeing is to keep the workspace together? But they otherwise do not depend on anything edition 2024?

@baloo baloo deleted the baloo/sec1/edition-2024 branch February 23, 2025 06:52
@tarcieri
Copy link
Member

tarcieri commented Feb 23, 2025

@baloo now is our opportunity to bump the edition, we should just do it everywhere

tarcieri pushed a commit to RustCrypto/traits that referenced this pull request Feb 23, 2025
@baloo
elliptic-curve: bump rand_core to 0.9.0 (#1751)
fbb4321 
This pulls:
 - RustCrypto/crypto-bigint#762
 - RustCrypto/crypto-bigint#765
 - zkcrypto/ff#122
 - zkcrypto/group#56
 - RustCrypto/MACs#178
 - RustCrypto/formats#1666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baloo @tarcieri