chore: Recompile more confs with the start_partition

[tchow-zlai]

Summary

• missed a few start_partition arguments.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Updated the starting partition date for event queries from 2023-11-01 to 2023-11-30, narrowing the data range considered in training set generation.
  • Added explicit start partition date for additional event queries to ensure consistent data selection.

[coderabbitai]

Walkthrough

The changes update the startPartition date from "2023-11-01" to "2023-11-30" in several training set join queries and add the startPartition key where it was previously missing. Only partition date parameters are affected; no logic or structure is altered.

Changes

File(s)	Change Summary
api/python/test/canary/compiled/joins/gcp/training_set.v1_dev__0, .../training_set.v1_test__0	Update "startPartition" in "left" events query from "2023-11-01" to "2023-11-30".
api/python/test/canary/compiled/joins/gcp/training_set.v1_dev_notds__0, .../training_set.v1_test_notds__0	Add "startPartition": "2023-11-30" to "left" events query.
api/python/test/canary/joins/gcp/training_set.py	Update start_partition parameter to "2023-11-30" in event queries; add if missing.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant TrainingSetQuery
    TestRunner->>TrainingSetQuery: Run join query with startPartition="2023-11-30"
    TrainingSetQuery->>DataSource: Fetch events from partition >= 2023-11-30
    DataSource-->>TrainingSetQuery: Return filtered event data
    TrainingSetQuery-->>TestRunner: Return join results

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• Fix join backfills when a new partition column is set for the Query #783: Introduces the "notds" partition column and related sources/joins, which this PR builds upon for date changes.
• fix: recompile all integ tests #987: Adds startPartition keys (with "2023-11-01") to similar queries; this PR updates those dates.
• feat: add a join to the gcp integration tests #727: Originally introduced the training_set.py join structure now updated here for partition filtering.

Suggested reviewers

• nikhil-zlai
• david-zlai

Poem

Dates have shifted, partitions anew,
November's thirtieth now guides us through.
Queries align, events in tow,
Testing the joins where data flows.
Review with care, the change is slight—
Partitioned progress, code set right!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab64ac3 and e03f0b2.

📒 Files selected for processing (5)

• api/python/test/canary/compiled/joins/gcp/training_set.v1_dev__0 (1 hunks)
• api/python/test/canary/compiled/joins/gcp/training_set.v1_dev_notds__0 (1 hunks)
• api/python/test/canary/compiled/joins/gcp/training_set.v1_test__0 (1 hunks)
• api/python/test/canary/compiled/joins/gcp/training_set.v1_test_notds__0 (1 hunks)
• api/python/test/canary/joins/gcp/training_set.py (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: piyush-zlai
PR: zipline-ai/chronon#33
File: cloud_aws/src/test/scala/ai/chronon/integrations/aws/DynamoDBKVStoreTest.scala:175-175
Timestamp: 2024-10-07T15:09:51.567Z
Learning: Hardcoding future timestamps in tests within `DynamoDBKVStoreTest.scala` is acceptable when data is generated and queried within the same time range, ensuring the tests remain valid over time.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)

• GitHub Check: join_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: spark_tests
• GitHub Check: batch_tests
• GitHub Check: python_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_commons_tests
• GitHub Check: service_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: api_tests
• GitHub Check: online_tests
• GitHub Check: aggregator_tests
• GitHub Check: flink_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (6)

api/python/test/canary/compiled/joins/gcp/training_set.v1_dev_notds__0 (1)

147-147: LGTM: Partition date addition is correct.

Adding startPartition to align with the coordinated update across training set variants.

api/python/test/canary/compiled/joins/gcp/training_set.v1_test__0 (1)

147-147: LGTM: Partition date update is correct.

Shifting start partition by 29 days as part of coordinated configuration update.

api/python/test/canary/compiled/joins/gcp/training_set.v1_dev__0 (1)

147-147: LGTM: Partition date update is correct.

Consistent partition date shift matching other variants.

api/python/test/canary/compiled/joins/gcp/training_set.v1_test_notds__0 (1)

147-147: LGTM: Partition date addition is correct.

Adding startPartition to maintain consistency across notds variants.

api/python/test/canary/joins/gcp/training_set.py (2)

18-18: LGTM: Source partition date update is correct.

Updated start_partition drives corresponding compiled configuration changes.

---

50-50: LGTM: Partition date addition is correct.

Adding start_partition to notds source ensures consistent partition filtering.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tchow/recompile-more-confs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.