Skip to content

try catch #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

try catch #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9402ddd
try catch
thomaschow Jul 23, 2025
0cb9685
update
thomaschow Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/scala/ai/chronon/api/planner/MonolithJoinPlanner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package ai.chronon.api.planner

import ai.chronon.api.Extensions.{GroupByOps, MetadataOps, WindowUtils}
import ai.chronon.api.Extensions.{GroupByOps, WindowUtils}
import ai.chronon.api.{Join, PartitionSpec, TableDependency, TableInfo}
import ai.chronon.planner
import ai.chronon.planner.Node
Expand Down
6 changes: 2 additions & 4 deletions api/src/test/scala/ai/chronon/api/test/planner/MonolithJoinPlannerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
package ai.chronon.api.test.planner

import ai.chronon.api.planner.{LocalRunner, MonolithJoinPlanner}
import ai.chronon.api
import ai.chronon.api.Builders.{Join, MetaData}
import ai.chronon.api.{ExecutionInfo, PartitionSpec}
import ai.chronon.api.planner.{LocalRunner, MonolithJoinPlanner}
import ai.chronon.api.{Builders, ExecutionInfo, PartitionSpec}
import ai.chronon.planner.{ConfPlan, Mode}
import org.scalatest.flatspec.AnyFlatSpec
import org.scalatest.matchers.should.Matchers

import java.nio.file.Paths
import scala.jdk.CollectionConverters._
import ai.chronon.api.Builders
import ai.chronon.api.Extensions.MetadataOps

class MonolithJoinPlannerTest extends AnyFlatSpec with Matchers {

Expand Down
11 changes: 9 additions & 2 deletions spark/src/main/scala/ai/chronon/spark/batch/BatchNodeRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,16 @@ object BatchNodeRunner extends NodeRunner {

val maybeMissingPartitions = inputTablesToRange.map {
case (tableName, maybePartitionRange) => {
tableName -> maybePartitionRange.map((requestedPR) =>
tableName -> maybePartitionRange.map((requestedPR) => {
// Need to normalize back again to the default spec before diffing against the existing partitions.
requestedPR.translate(tableUtils.partitionSpec).partitions.diff(allInputTablePartitions(tableName)))
try {
requestedPR.translate(tableUtils.partitionSpec).partitions.diff(allInputTablePartitions(tableName))
} catch {
case e: Exception =>
logger.error(s"Error computing missing partitions for table $tableName.")
throw e
}
})
}
}
val kvStoreUpdates = kvStore.multiPut(allInputTablePartitions.map { case (tableName, allPartitions) =>
Expand Down
Loading