try catch

[tchow-zlai]

Summary

• Add more logging

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Improved error logging for failures during missing partition computation, providing clearer information when issues occur.

[coderabbitai]

Walkthrough

A try-catch block was introduced in the runFromArgs method of BatchNodeRunner.scala to log errors when computing missing partitions for input tables. If an exception occurs during this process, it is logged with the table name, then rethrown. No other logic or control flow changes were made.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/.../BatchNodeRunner.scala	Added try-catch for error logging during missing partition computation
api/src/main/scala/ai/chronon/api/planner/MonolithJoinPlanner.scala	Removed unused import of MetadataOps
api/src/test/scala/ai/chronon/api/test/planner/MonolithJoinPlannerTest.scala	Reorganized and consolidated imports; removed unused imports

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• feat: batch node runner #870: Initial implementation of BatchNodeRunner and core run methods, related as this PR builds on it.
• feat: persist table partitions in kvstore ZIP-727 ZIP-728 ZIP-733 #964: Comprehensive partition handling and validation in BatchNodeRunner.runFromArgs, related to error handling additions here.

Suggested reviewers

• piyush-zlai
• david-zlai
• varant-zlai

Poem

When partitions go missing, don’t fret or despair,
Now errors are logged with exceptional care.
A try and a catch, for tables in need,
The logs will now tell you which table to heed.
Debugging’s a breeze—let’s give it a cheer!
For clearer exceptions, the path is now clear.

Note

⚡️ Unit Test Generation - Beta

CodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9402ddd and 0cb9685.

📒 Files selected for processing (3)

• api/src/main/scala/ai/chronon/api/planner/MonolithJoinPlanner.scala (1 hunks)
• api/src/test/scala/ai/chronon/api/test/planner/MonolithJoinPlannerTest.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/batch/BatchNodeRunner.scala (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• api/src/main/scala/ai/chronon/api/planner/MonolithJoinPlanner.scala
• api/src/test/scala/ai/chronon/api/test/planner/MonolithJoinPlannerTest.scala

🚧 Files skipped from review as they are similar to previous changes (1)

• spark/src/main/scala/ai/chronon/spark/batch/BatchNodeRunner.scala

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)

• GitHub Check: online_tests
• GitHub Check: api_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: service_commons_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_tests
• GitHub Check: flink_tests
• GitHub Check: aggregator_tests
• GitHub Check: analyzer_tests
• GitHub Check: streaming_tests
• GitHub Check: groupby_tests
• GitHub Check: batch_tests
• GitHub Check: join_tests
• GitHub Check: spark_tests
• GitHub Check: fetcher_tests
• GitHub Check: scala_compile_fmt_fix

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tchow/add-more-logging

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.