chore: remove inputPartitionColumn

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor

  • Unified and simplified partition specification handling across join and utility operations, removing redundant parameters and ensuring consistent determination of partition columns.

• Bug Fixes

  • Improved accuracy in computing unfilled ranges and partition details, reducing errors caused by partition column mismatches.

[coderabbitai]

Walkthrough

This change refactors partition handling in join-related Spark utilities. It replaces the use of partition column name strings with partition specification objects throughout methods like unfilledRanges and partitions, simplifying parameter lists and unifying partition column resolution under the PartitionSpec abstraction.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/Analyzer.scala	Updated analyzeJoin to pass partition spec objects instead of column name strings to unfilledRanges.
spark/src/main/scala/ai/chronon/spark/JoinBase.scala	Removed partition column name arguments from calls to unfilledRanges and partitions, using partition specs.
spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala	Removed partitionColumnName and inputPartitionColumnNames parameters; refactored methods to use PartitionSpec for partition column resolution; simplified unfilledRanges logic.
spark/src/main/scala/ai/chronon/spark/Driver.scala	Changed CheckPartitions.run to use PartitionSpec instead of partition column name string in partitions call.

Sequence Diagram(s)

sequenceDiagram
    participant Analyzer
    participant JoinBase
    participant TableUtils

    Analyzer->>JoinBase: analyzeJoin()
    JoinBase->>TableUtils: unfilledRanges(inputPartitionSpecs)
    TableUtils->>TableUtils: Use PartitionSpec for partition columns
    TableUtils-->>JoinBase: Return unfilled ranges
    JoinBase-->>Analyzer: Join analysis result

Loading

Possibly related PRs

• zipline-ai/chronon#547: Related update to CheckPartitions.run using PartitionSpec.
• zipline-ai/chronon#659: Changes partition column name arguments to sequences of strings in unfilledRanges.
• zipline-ai/chronon#823: Earlier refactor of unfilledRanges calls to use partition column names from partition specs.

Suggested reviewers

• piyush-zlai
• david-zlai

Poem

Partition specs now lead the way,
No more strings to go astray!
Columns unified, confusion gone,
Code refactored, logic strong.
Spark joins march with specs in hand—
Partition order, neat and grand!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c874ef7 and 17f93d7.

📒 Files selected for processing (4)

• spark/src/main/scala/ai/chronon/spark/Analyzer.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/Driver.scala (2 hunks)
• spark/src/main/scala/ai/chronon/spark/JoinBase.scala (2 hunks)
• spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (4)

• spark/src/main/scala/ai/chronon/spark/JoinBase.scala
• spark/src/main/scala/ai/chronon/spark/Analyzer.scala
• spark/src/main/scala/ai/chronon/spark/Driver.scala
• spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: scala_compile_fmt_fix
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: groupby_tests
• GitHub Check: join_tests
• GitHub Check: fetcher_tests
• GitHub Check: batch_tests
• GitHub Check: spark_tests
• GitHub Check: enforce_triggered_workflows

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.