chore: Leverage api extensions for partitioning

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Standardized how partition columns and specifications are referenced, improving consistency in partition handling across features.
  • Removed internal extension methods related to partition properties, simplifying the codebase.
• Style
  • Improved code readability with organized imports and refined formatting.

[coderabbitai]

Walkthrough

This change refactors how partition columns and partition specifications are referenced throughout several Spark modules. Direct property accesses like effectivePartitionColumn are replaced with calls to partitionSpec(...).column, ensuring partition information is consistently derived from the query and table utilities. Some extension methods are removed, and import statements are reorganized.

Changes

Files	Change Summary
spark/src/main/scala/ai/chronon/spark/Analyzer.scala	Refactored partition column access to use partitionSpec(...).column; imports reorganized.
spark/src/main/scala/ai/chronon/spark/BootstrapInfo.scala	Updated key filtering and scan logic to use partitionSpec(...).column.
spark/src/main/scala/ai/chronon/spark/Extensions.scala	Removed implicit extension classes for partition-related methods; cleaned up related imports.
spark/src/main/scala/ai/chronon/spark/GroupBy.scala	Changed partition spec derivation to use query.partitionSpec(...); imports consolidated.
spark/src/main/scala/ai/chronon/spark/JoinBase.scala	Unified partition spec and column access via query.partitionSpec(...).column in join operations.
spark/src/main/scala/ai/chronon/spark/JoinUtils.scala	Replaced direct partition spec access with query.partitionSpec(...) in join utilities.
spark/src/main/scala/ai/chronon/spark/batch/JoinBootstrapJob.scala	Changed DataFrame scan to use partitionSpec(...).column for partition key; import updated to wildcard.
api/src/main/scala/ai/chronon/api/Extensions.scala	Added null-safety when accessing optional partition fields in partitionSpec method.

Sequence Diagram(s)

sequenceDiagram
  participant Query
  participant TableUtils
  participant SparkComponent

  SparkComponent->>Query: partitionSpec(tableUtils.partitionSpec)
  Query->>TableUtils: Use tableUtils.partitionSpec as fallback
  Query-->>SparkComponent: Return PartitionSpec (with .column)
  SparkComponent->>SparkComponent: Use PartitionSpec.column for partition operations

Loading

Possibly related PRs

• Fix join backfills when a new partition column is set for the Query #783: Refactors partition column/spec access in joins and scans, directly paralleling these changes.
• Allow setting partition column name in sources #381: Introduced and later modified effectivePartitionColumn and partition column handling, closely related.
• Moving PartitionRange out of spark into online #15: Updates partition spec usage in Analyzer.scala, mirroring this PR’s approach.

Suggested reviewers

• nikhil-zlai
• varant-zlai
• piyush-zlai

Poem

Partition columns, once scattered wide,
Now gathered close, no need to hide.
Specs and columns, unified and neat,
Code refactored, oh what a feat!
Spark now hums a tidier tune,
As queries dance beneath the moon.
✨🗂️

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

api/src/main/scala/ai/chronon/api/Extensions.scala (1)

1191-1193: Simplify lambda syntax.

Remove unnecessary parentheses around lambda parameters.

-      val column = Option(query).flatMap((q) => Option(q.partitionColumn)).getOrElse(defaultSpec.column)
-      val format = Option(query).flatMap((q) => Option(q.partitionFormat)).getOrElse(defaultSpec.format)
-      val interval = Option(query).flatMap((q) => Option(q.partitionInterval)).getOrElse(WindowUtils.Day)
+      val column = Option(query).flatMap(q => Option(q.partitionColumn)).getOrElse(defaultSpec.column)
+      val format = Option(query).flatMap(q => Option(q.partitionFormat)).getOrElse(defaultSpec.format)  
+      val interval = Option(query).flatMap(q => Option(q.partitionInterval)).getOrElse(WindowUtils.Day)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98dacff and 53ca504.

📒 Files selected for processing (1)

• api/src/main/scala/ai/chronon/api/Extensions.scala (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

api/src/main/scala/ai/chronon/api/Extensions.scala (1)

api/src/main/java/ai/chronon/api/thrift/Option.java (1)

• Option (25-143)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: spark_tests
• GitHub Check: batch_tests
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: service_commons_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_tests
• GitHub Check: api_tests
• GitHub Check: online_tests
• GitHub Check: aggregator_tests
• GitHub Check: flink_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (1)

api/src/main/scala/ai/chronon/api/Extensions.scala (1)

1191-1194: Good null safety enhancement.

The flatMap pattern correctly prevents NPEs when query is null.