Vz/label join add rounding to window size

[varant-zlai]

Summary

Users can set a flag which will treat sub-day windows as 0 day offsets for label join. I.e. a 2 hour label window will join against the same day of join output instead of the default of using a 1 day offset.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features

  • Introduced a configuration option to control rounding of sub-day windows during label join operations, allowing for conditional rounding down or up.

• Bug Fixes

  • Enhanced label join computations by supporting configurable rounding strategies for sub-day windows.

• Tests

  • Added a test verifying correct behavior when rounding down sub-day windows is enabled through configuration.

[coderabbitai]

Walkthrough

This change adds a configuration flag to control whether sub-day aggregation windows round down or up in label joins. The rounding logic and comments in LabelJoinV2 were updated accordingly. A new test verifies correct behavior when rounding down is enabled.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala	Conditional rounding of sub-day windows based on new config flag; updated comments.
spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala	Added roundDownHourOffset boolean flag from Spark config.
spark/src/test/scala/ai/chronon/spark/test/batch/LabelJoinV2Test.scala	Added test for sub-day window rounding down; introduced helper date val.

Sequence Diagram(s)

sequenceDiagram
    participant Test as LabelJoinV2Test
    participant Spark as SparkSession
    participant TableUtils
    participant LabelJoin as LabelJoinV2

    Test->>Spark: Set config "round_down_sub_day_windows"=true
    Test->>TableUtils: Instantiate with Spark config
    TableUtils-->>LabelJoin: Provide roundDownHourOffset flag
    LabelJoin->>LabelJoin: Apply sub-day window rounding (down or up)
    LabelJoin-->>Test: Return join results
    Test->>Test: Compare results to expected output

Loading

Possibly related PRs

• Simple LabelJoin flow #546: Initial implementation of LabelJoinV2, laying groundwork for current rounding and config changes.
• [spark] bugfix label join steps #687: Modifies getWindowToLabelOutputInfos method but focuses on partition range handling.
• Update LabelJoin to support sub-day windows and temporal accuracy #636: Adds sub-day window support and temporal accuracy in LabelJoinV2, related to rounding logic.

Suggested reviewers

• nikhil-zlai
• tchow-zlai

Poem

Rounding up, or rounding down,
Sub-day windows wear the crown.
A toggle flips, the logic bends,
Now tests ensure it all depends.
Config set, the join is neat—
Precision marching on its feet!
🕒✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5f75a6 and 0cb8514.

📒 Files selected for processing (3)

• spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala (1 hunks)
• spark/src/test/scala/ai/chronon/spark/test/batch/LabelJoinV2Test.scala (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala
• spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala
• spark/src/test/scala/ai/chronon/spark/test/batch/LabelJoinV2Test.scala

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: analyzer_tests
• GitHub Check: groupby_tests
• GitHub Check: join_tests
• GitHub Check: fetcher_tests
• GitHub Check: streaming_tests
• GitHub Check: batch_tests
• GitHub Check: spark_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.