[spark] bugfix label join steps

[varant-zlai]

Summary

Fix the bug where label join doesn't step properly on creating the left dataframe.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Improved variable names and updated method signatures for better clarity in partition range handling during label join operations.

[coderabbitai]

Walkthrough

This change refactors the LabelJoinV2 class by renaming a private variable for clarity and updating method signatures to accept a PartitionRange parameter. All relevant references and method calls are adjusted accordingly. The mapping of window-to-label output info is now computed relative to specific day partition ranges, rather than the overall label date range. No changes are made to control flow or error handling.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala	- Renamed labelDsAsPartitionRange to labelRangeAsPartitionRange. - Updated getWindowToLabelOutputInfos to take a PartitionRange parameter. - Modified all calls to pass the correct partition range. - Adjusted computeDay to use a local PartitionRange for per-day computation.

Possibly related PRs

• Simple LabelJoin flow #546: Introduces the initial implementation of LabelJoinV2, which is directly refactored by this PR.
• Update LabelJoin to support sub-day windows and temporal accuracy #636: Modifies LabelJoinV2 for temporal accuracy and sub-day window support, overlapping with this PR’s changes to partition range handling.

Suggested reviewers

• nikhil-zlai
• tchow-zlai

Poem

A variable’s name, now crystal clear,
Partition ranges passed with cheer.
Day by day, the logic flows,
Where windowed labels neatly go.
Refactored code, concise and bright—
Small changes make it right!
🛠️✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 5e1f5b3 and f64bff7.

📒 Files selected for processing (1)

• spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: streaming_tests
• GitHub Check: streaming_tests
• GitHub Check: spark_tests
• GitHub Check: spark_tests
• GitHub Check: join_tests
• GitHub Check: join_tests
• GitHub Check: batch_tests
• GitHub Check: analyzer_tests
• GitHub Check: fetcher_tests
• GitHub Check: groupby_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: batch_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: analyzer_tests

🔇 Additional comments (6)

spark/src/main/scala/ai/chronon/spark/batch/LabelJoinV2.scala (6)

42-42: Good variable rename

Renaming labelDsAsPartitionRange to labelRangeAsPartitionRange better reflects its purpose as the full label date range converted to a partition range.

---

51-51: LGTM

Updated reference to the renamed variable.

---

80-80: Fixed bug in method signature

Changed method to accept explicit parameter instead of using class-wide value, fixing the core issue where label join wasn't using the correct date partitions.

---

126-126: LGTM

Iterates through label range steps correctly.

---

136-137: Bug fix - proper partition initialization

Creates a single-day partition range for the label day being processed, solving the bug where computation was using the entire date range.

---

141-141: LGTM

Now correctly passes the single-day partition range to the method, completing the bugfix.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.