Skip to content

chore: Integration Tests Notify Specific Slack Channels #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

chore: Integration Tests Notify Specific Slack Channels #584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f7a8e
Send messages to relevant channels on failure of the integration tests
chewy-zlai Apr 3, 2025
6aacf0a
Update message to indicate which tests failed
chewy-zlai Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions .github/workflows/push_to_canary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,15 +257,31 @@ jobs:
role-to-assume: arn:aws:iam::${{secrets.AWS_ACCOUNT_ID}}:role/github_actions
aws-region: ${{secrets.AWS_REGION}}


# TODO Test 'run' commands when they are ready
- name: Run Quickstart Integration Tests
id: aws_integration_tests
shell: bash
run: |
set -xo pipefail
./scripts/distribution/run_aws_quickstart.sh --canary

- name: On Fail Notify Slack
id: notify_slack
if: failure()
uses: slackapi/slack-github-action@v1
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_AWS_WEBHOOK_URL }}
with:
payload: |
{
"text": "Zipline AWS CI Tests Failed\n\n The integration tests failed for commit <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.sha }}> on branch ${{ github.ref }}. Please check the logs for more details.",
"attachments": [
{
"text": "",
"color": "#ff0000"
}
]
}


run_gcp_integration_tests:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -297,6 +313,23 @@ jobs:
set -xo pipefail
./scripts/distribution/run_gcp_quickstart.sh --canary

- name: On Fail Notify Slack
id: notify_slack
if: failure()
uses: slackapi/slack-github-action@v1
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GCP_WEBHOOK_URL }}
with:
payload: |
{
"text": "Zipline GCP CI Tests Failed\n\n The integration tests failed for commit <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.sha }}> on branch ${{ github.ref }}. Please check the logs for more details.",
"attachments": [
{
"text": "",
"color": "#ff0000"
}
]
}

push_to_aws_passing:
needs: [ build_artifacts, run_gcp_integration_tests, run_aws_integration_tests ]
Expand Down Expand Up @@ -471,7 +504,7 @@ jobs:
- name: Send Failure Notification
uses: slackapi/slack-github-action@v1
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_TESTS_WEBHOOK_URL }}
with:
payload: |
{
Expand Down