chore: Integration Tests Notify Specific Slack Channels #584
Conversation
WalkthroughThe changes add conditional Slack notification steps to the GitHub Actions workflow for AWS and GCP integration tests. If tests fail, a new "On Fail Notify Slack" step triggers a notification using Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Runner
participant Test as Integration Test Job
participant Slack as Slack Notification Step
participant API as Slack API
Runner->>Test: Run integration tests
Test-->>Runner: Failure detected
Runner->>Slack: Trigger "On Fail Notify Slack"
Slack->>API: Send notification via slackapi/slack-github-action@v1
API-->>Slack: Acknowledge notification
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/push_to_canary.yaml (2)
267-284: Fix extra spaces in AWS Slack step name.
Remove the extra space after the colon in- name: On Fail Notify Slack.- - name: On Fail Notify Slack + - name: On Fail Notify Slack🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 267-267: too many spaces after colon
(colons)
316-333: Fix extra spaces in GCP Slack step name.
Similarly, remove the extra space in- name: On Fail Notify Slack.- - name: On Fail Notify Slack + - name: On Fail Notify Slack🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 316-316: too many spaces after colon
(colons)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
.github/workflows/push_to_canary.yaml(3 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/push_to_canary.yaml
[warning] 267-267: too many spaces after colon
(colons)
[warning] 316-316: too many spaces after colon
(colons)
🔇 Additional comments (1)
.github/workflows/push_to_canary.yaml (1)
507-507: Confirm webhook secret update.
TheSLACK_WEBHOOK_URLis now set to${{ secrets.SLACK_TESTS_WEBHOOK_URL }}. Please verify that this secret is correctly configured for failure notifications.
## Summary Update Integration Tests to update aws-crew and gcp-crew for integration test failures. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added automated Slack notifications that alert the team immediately upon integration test failures in both AWS and GCP environments. - **Chores** - Updated notification settings to ensure alerts are routed to the correct Slack channel for effective troubleshooting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Update Integration Tests to update aws-crew and gcp-crew for integration test failures.
Checklist
Summary by CodeRabbit
New Features
Chores