Skip to content

update code to use . instead of / #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

update code to use . instead of / #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d532021
use module path in drift handler and observability demo
ken-zlai Feb 25, 2025
2e0a86c
remove unneccecary frontend code since path has changed
ken-zlai Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/routes/[conf]/[name]/observability/distributions/+page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const load = async ({ parent, fetch }) => {
const { conf, joinDrift, dateRange } = await parent();
const api = new Api({ fetch });

const confName = conf?.metaData?.name?.replace('/', '.') ?? 'Unknown';
const confName = conf?.metaData?.name ?? 'Unknown';
const columnNames = joinDrift?.driftSeries.map((ds) => ds.key?.column ?? 'Unknown') ?? [];

// Fetch percentile data for each column
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/routes/[conf]/[name]/observability/drift/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@

if (seriesPoint) {
try {
const joinName = data.conf?.metaData?.name?.replace('/', '.') ?? 'Unknown';
const joinName = data.conf?.metaData?.name ?? 'Unknown';
const columnName = seriesPoint.series.key.toString();

// TODO: Add loading and error states
Expand Down
10 changes: 4 additions & 6 deletions hub/src/main/scala/ai/chronon/hub/handlers/DriftHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ class DriftHandler(driftStore: DriftStore) {
}

val window = new Window(offsetDuration.toMinutes.toInt, TimeUnit.MINUTES)
val joinPath = req.getName.replaceFirst("\\.", "/")
logger.debug(s"Querying drift store with window: $window, joinPath: $joinPath")
logger.debug(s"Querying drift store with window: $window, name: $req.getName")

driftStore.getDriftSeries(
joinPath,
req.getName,
req.getAlgorithm,
window,
req.getStartTs,
Expand Down Expand Up @@ -82,11 +81,10 @@ class DriftHandler(driftStore: DriftStore) {
def getColumnSummary(req: JoinSummaryRequest): TileSummarySeries = {
logger.debug(s"Processing summary request for join: ${req.getName}, column: ${req.getColumnName}")

val joinPath = req.getName.replaceFirst("\\.", "/")
logger.debug(s"Querying summary store with joinPath: $joinPath")
logger.debug(s"Querying summary store with name: $req.getName")

driftStore.getSummarySeries(
joinPath,
req.getName,
req.getStartTs,
req.getEndTs,
Some(req.getColumnName)
Expand Down
5 changes: 2 additions & 3 deletions spark/src/main/scala/ai/chronon/spark/scripts/ObservabilityDemo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,12 @@ object ObservabilityDemo {
val name = "dim_user_account_type"
val window = new Window(10, ai.chronon.api.TimeUnit.HOURS)

val joinPath = joinName.replaceFirst("\\.", "/")
logger.info("Looking up current summary series")
val maybeCurrentSummarySeries = driftStore.getSummarySeries(joinPath, startTs, endTs, Some(name)).get
val maybeCurrentSummarySeries = driftStore.getSummarySeries(joinName, startTs, endTs, Some(name)).get
val currentSummarySeries = Await.result(maybeCurrentSummarySeries, Duration.create(10, TimeUnit.SECONDS))
logger.info("Now looking up baseline summary series")
val maybeBaselineSummarySeries =
driftStore.getSummarySeries(joinPath, startTs - window.millis, endTs - window.millis, Some(name))
driftStore.getSummarySeries(joinName, startTs - window.millis, endTs - window.millis, Some(name))
val baselineSummarySeries = Await.result(maybeBaselineSummarySeries.get, Duration.create(10, TimeUnit.SECONDS))

logger.info(s"Current summary series: $currentSummarySeries")
Expand Down