update code to use . instead of /

[ken-zlai]

Summary

#398 updated the module path from "/" to ".", but not all code was migrated to the new convention, causing frontend API calls to fail when retrieving joins.

@david-zlai – Can you review the code to ensure it fully aligns with the new convention?
@sean-zlai – Can you tear down all Docker images and rebuild on this branch to confirm observability works as expected?

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Streamlined how configuration names are handled in observability views. Names are now displayed as originally provided without extra formatting, ensuring a consistent and straightforward presentation. The fallback label remains “Unknown” when a name is not available.

[coderabbitai]

Walkthrough

The changes remove prior string replacement logic in both frontend and backend files. In the frontend, configuration names are now set directly without altering slashes to periods. In the backend, the intermediary joinPath variable is eliminated and replaced by directly using the provided name. Fallback behavior remains unchanged in all cases.

Changes

Files	Summary
frontend/src/routes/[conf]/[name]/observability/(distributions/+page.ts, drift/+page.svelte)	Removed string replacement in assigning configuration names; now assigns directly with fallback 'Unknown'.
hub/src/main/scala/ai/chronon/.../(DriftHandler.scala, ObservabilityDemo.scala)	Eliminated intermediary joinPath; directly uses req.getName in logging and method calls.

Suggested reviewers

• david-zlai
• sean-zlai
• nikhil-zlai

Poem

Code paths refined with precision and ease,
No more string twists to confuse or tease.
Drift and join now stand true and clear,
Direct values shine, simple and sincere.
CodeRabbit grins at this tidy spree!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4f579b4 and 2e0a86c.

📒 Files selected for processing (4)

• frontend/src/routes/[conf]/[name]/observability/distributions/+page.ts (1 hunks)
• frontend/src/routes/[conf]/[name]/observability/drift/+page.svelte (1 hunks)
• hub/src/main/scala/ai/chronon/hub/handlers/DriftHandler.scala (2 hunks)
• spark/src/main/scala/ai/chronon/spark/scripts/ObservabilityDemo.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: streaming_tests
• GitHub Check: streaming_tests
• GitHub Check: spark_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: join_tests
• GitHub Check: groupby_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: fetcher_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: analyzer_tests
• GitHub Check: non_spark_tests
• GitHub Check: spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: frontend_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (8)

frontend/src/routes/[conf]/[name]/observability/drift/+page.svelte (1)

90-90: Good simplification of path handling.

Directly using original name without string replacement aligns with PR #398's module path change.

frontend/src/routes/[conf]/[name]/observability/distributions/+page.ts (1)

7-7: Direct name assignment looks good.

Consistent with other changes in this PR.

hub/src/main/scala/ai/chronon/hub/handlers/DriftHandler.scala (4)

38-38: Removed joinPath var, using name directly.

Properly aligns with module path convention change.

---

41-41: Using req.getName directly in method call.

Consistent with logging change above.

---

84-84: Direct name usage in log message.

Follows the same pattern as other changes.

---

87-87: Direct name usage in method call.

Consistently applies new convention.

spark/src/main/scala/ai/chronon/spark/scripts/ObservabilityDemo.scala (2)

159-159: Using joinName directly without transformation.

Consistent with changes in other files, properly implements dot notation.

---

163-163: Removed path transformation in baseline lookup.

Same pattern as the current summary lookup above.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[david-zlai]

This looks right to me.

the join names or names of any chronon confs should never have /'s -> https://github.com/zipline-ai/chronon/blob/main/api/py/ai/chronon/repo/extract_objects.py#L78

I'll be adding some assertion logic to make sure we join names with /'s don't show up

[sean-zlai]

Thanks @ken-zlai! Let me finish this refactor I'm in the middle of then I'll update my local env off this branch.

[sean-zlai]

@ken-zlai looks good, thanks!