feat: make the thrift get cross platform compat

[tchow-zlai]

Summary

• Make the thrift gen python executable, use py_binary to support python generally

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Enhanced the build process for a key automation tool by streamlining its execution and command handling, leading to improved overall build reliability and performance.
  • Transitioned the export mechanism of a Python script to a defined executable binary target for better integration within the build system.

[coderabbitai]

Walkthrough

This pull request updates the Bazel build configuration for handling the thrift_package_replace target. In the scripts/codemod/BUILD.bazel file, the export of the Python script is replaced with a py_binary rule. Additionally, the tools/build_rules/thrift/thrift.bzl file is modified to reference the Python script as an executable target, updates the command execution method from run_shell to run, and changes the argument format. These modifications adjust how the script is executed within the build system.

Changes

File(s)	Change Summary
scripts/codemod/BUILD.bazel	Replaced exports_files(["thrift_package_replace.py"]) with a py_binary rule making thrift_package_replace executable, specifying the source and main entry point.
tools/build_rules/thrift/thrift.bzl	Updated script reference from ctx.file._python_script to ctx.executable._python_script; changed command execution from run_shell to run with argument list; revised default label for _python_script to be executable with host configuration.

Sequence Diagram(s)

sequenceDiagram
    participant Bazel as Bazel Build System
    participant Binary as py_binary("thrift_package_replace")
    participant Thrift as Thrift Build Rule

    Bazel->>Binary: Invoke binary target
    Binary->>Thrift: Execute Python script via ctx.actions.run
    Thrift-->>Binary: Return execution result
    Binary-->>Bazel: Complete target execution

Loading

Possibly related PRs

• fix: update the jar paths and thrift.bzl #317: Updates in the handling of the Python script's export and its integration as an executable target show a direct code-level connection with these changes.
• fix: thrift --gen was outputting incorrectly in a nested fashion #219: Related modifications to Thrift script execution and references in the Bazel build system.
• feat: upgrade artifact upload to use bazel #314: Enhancements in the handling of Python scripts within the Bazel build process align with changes made in this PR.

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• chewy-zlai
• varant-zlai

Poem

In Bazel’s realm, a new rule shines bright,
Python scripts transformed to executable might,
From export to binary a nimble switch made,
Command flows now clear, no longer delayed,
Code sings its tune under build system light!
🚀✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between dd348b1 and d3867bd.

📒 Files selected for processing (2)

• scripts/codemod/BUILD.bazel (1 hunks)
• tools/build_rules/thrift/thrift.bzl (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• tools/build_rules/thrift/thrift.bzl
• scripts/codemod/BUILD.bazel

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: bazel_config_tests
• GitHub Check: enforce_triggered_workflows

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.