fix: update the jar paths and thrift.bzl

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Streamlined the build process with more consistent naming conventions for cloud deployment artifacts.
• New Features
  • Enhanced support for macOS environments by introducing platform-specific handling during the build, ensuring improved compatibility.

[coderabbitai]

Walkthrough

The pull request updates the GCP artifacts build script by renaming the Bazel build commands and corresponding variable assignments to adopt a consistent naming convention with a cloud_gcp_ prefix. Additionally, it modifies the Thrift build rules to introduce platform-specific handling for the Thrift binary, using a macOS-specific path when applicable.

Changes

File	Change Summary
distribution/build_and_upload_gcp_artifacts.sh	Updated Bazel build commands and variable assignments to rename JAR files with the cloud_gcp_ prefix.
tools/build_rules/thrift/thrift.bzl	Modified thrift_java_library to select a platform-specific Thrift binary path for macOS.

Sequence Diagram(s)

sequenceDiagram
    participant F as thrift_java_library
    participant OS as System Environment

    F->>OS: Detect platform
    alt Platform is macOS
        OS-->>F: Return "/opt/homebrew/bin/thrift"
    else
        OS-->>F: Return "/usr/local/bin/thrift"
    end

Loading

Possibly related PRs

• Add script to upload cloud gcp jars to appropriate bucket. #203: Modifies the same build script with similar JAR renaming changes.
• feat: upgrade artifact upload to use bazel #314: Adjusts constants for JAR files in run.py, aligning with the naming updates in this PR.

Suggested reviewers

• piyush-zlai
• chewy-zlai
• nikhil-zlai
• david-zlai

Poem

In the realm of code so bright,
Cloud jars gleam in new attire,
Paths adjust with keen insight,
macOS finds its thrift-inspired fire,
Revisions dance and codes conspire,
Cheers to updates that lift us higher!
🚀✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between dc789a2 and 2d82117.

📒 Files selected for processing (2)

• distribution/build_and_upload_gcp_artifacts.sh (1 hunks)
• tools/build_rules/thrift/thrift.bzl (1 hunks)

🔇 Additional comments (2)

distribution/build_and_upload_gcp_artifacts.sh (2)

48-49: LGTM: JAR paths updated to match new naming

Path variables correctly reflect the new JAR names.

---

45-46: Verify bazel target names

✅ Verification successful

Bazel target names are consistent.

• build_and_upload_gcp_artifacts.sh now builds the correct targets.
• References in api/py/ai/chronon/repo/run.py match these names.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the new bazel targets exist
bazel query //cloud_gcp:cloud_gcp_lib_deploy.jar
bazel query //cloud_gcp:cloud_gcp_submitter_deploy.jar

Length of output: 299

---

Script:

#!/bin/bash
# Search for target definitions or references in the repository
rg -n "cloud_gcp_lib_deploy\.jar" .
rg -n "cloud_gcp_submitter_deploy\.jar" .

Length of output: 761

[coderabbitai]

💡 Codebase verification

Thrift binary missing on Linux

• The script warned that /usr/local/bin/thrift is not found on Linux.
• Confirm the expected binary installation or adjust the path accordingly.

🔗 Analysis chain

Verify thrift binary paths exist

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if thrift binary exists in expected paths
if [[ "$OSTYPE" == "darwin"* ]]; then
  if [ ! -f "/opt/homebrew/bin/thrift" ]; then
    echo "Warning: Thrift binary not found at /opt/homebrew/bin/thrift"
  fi
else
  if [ ! -f "/usr/local/bin/thrift" ]; then
    echo "Warning: Thrift binary not found at /usr/local/bin/thrift"
  fi
fi

Length of output: 198