Skip to content

fix: update the jar paths and thrift.bzl #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
+5 −4
Merged

fix: update the jar paths and thrift.bzl #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions distribution/build_and_upload_gcp_artifacts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ sbt clean
sbt flink/assembly
sbt service/assembly

bazel build //cloud_gcp:lib_deploy.jar
bazel build //cloud_gcp:submitter_deploy.jar
bazel build //cloud_gcp:cloud_gcp_lib_deploy.jar
bazel build //cloud_gcp:cloud_gcp_submitter_deploy.jar

CLOUD_GCP_JAR="$CHRONON_ROOT_DIR/bazel-bin/cloud_gcp/lib_deploy.jar"
CLOUD_GCP_SUBMITTER_JAR="$CHRONON_ROOT_DIR/bazel-bin/cloud_gcp/submitter_deploy.jar"
CLOUD_GCP_JAR="$CHRONON_ROOT_DIR/bazel-bin/cloud_gcp/cloud_gcp_lib_deploy.jar"
CLOUD_GCP_SUBMITTER_JAR="$CHRONON_ROOT_DIR/bazel-bin/cloud_gcp/cloud_gcp_submitter_deploy.jar"
FLINK_JAR="$CHRONON_ROOT_DIR/flink/target/scala-2.12/flink-assembly-0.1.0-SNAPSHOT.jar"
SERVICE_JAR="$CHRONON_ROOT_DIR/service/target/scala-2.12/service-0.1.0-SNAPSHOT.jar"

Expand Down
1 change: 1 addition & 0 deletions tools/build_rules/thrift/thrift.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def thrift_java_library(name, srcs, **kwargs):
name = name,
srcs = srcs,
thrift_binary = select({
"@platforms//os:macos": "/opt/homebrew/bin/thrift",
"//conditions:default": "/usr/local/bin/thrift",
}),
Comment on lines 108 to 111
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Thrift binary missing on Linux

  • The script warned that /usr/local/bin/thrift is not found on Linux.
  • Confirm the expected binary installation or adjust the path accordingly.
🔗 Analysis chain

Verify thrift binary paths exist

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if thrift binary exists in expected paths
if [[ "$OSTYPE" == "darwin"* ]]; then
  if [ ! -f "/opt/homebrew/bin/thrift" ]; then
    echo "Warning: Thrift binary not found at /opt/homebrew/bin/thrift"
  fi
else
  if [ ! -f "/usr/local/bin/thrift" ]; then
    echo "Warning: Thrift binary not found at /usr/local/bin/thrift"
  fi
fi

Length of output: 198

**kwargs
Expand Down