Skip to content

Only download the dataproc jar if on dataproc mode #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Only download the dataproc jar if on dataproc mode #235

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26b2180
Only download the dataproc jar if on dataproc mode
david-zlai Jan 17, 2025
6c50eec
sorry for changing
david-zlai Jan 17, 2025
ee2578b
Revert "Only download the dataproc jar if on dataproc mode"
david-zlai Jan 17, 2025
44b1313
just the change
david-zlai Jan 17, 2025
02ae582
flake8 stuff
david-zlai Jan 17, 2025
5aad967
fix line too long
david-zlai Jan 17, 2025
a54731d
fix format
david-zlai Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions api/py/ai/chronon/repo/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,10 +522,10 @@ def run(self):
else:
# offline mode

# we'll always download the jar for now so that we can pull
# Always download the jar for now in dataproc mode so that we can pull
# in any fixes or latest changes
dataproc_jar = download_dataproc_jar(temp_dir,
get_customer_id())
if self.dataproc:
dataproc_jar = download_dataproc_jar(temp_dir, get_customer_id())

if self.parallelism > 1:
assert self.start_ds is not None and self.ds is not None, (
Expand All @@ -538,8 +538,8 @@ def run(self):
for start_ds, end_ds in date_ranges:
if not self.dataproc:
command = (
"bash {script} --class ai.chronon.spark.Driver {jar} {subcommand} {args} "
+ "{additional_args}"
"bash {script} --class ai.chronon.spark.Driver " +
"{jar} {subcommand} {args} {additional_args}"
).format(
script=self.spark_submit,
jar=self.jar_path,
Expand Down Expand Up @@ -580,8 +580,8 @@ def run(self):
else:
if not self.dataproc:
command = (
"bash {script} --class ai.chronon.spark.Driver {jar} {subcommand} {args} " +
"{additional_args}"
"bash {script} --class ai.chronon.spark.Driver "
+ "{jar} {subcommand} {args} {additional_args}"
).format(
script=self.spark_submit,
jar=self.jar_path,
Expand Down
Loading