Only download the dataproc jar if on dataproc mode

[david-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Style
  • Streamlined command construction for better readability.
  • Improved code formatting and readability across multiple functions.
  • Enhanced dictionary and string formatting.
  • Consistent error message presentation.
• Bug Fixes
  • Updated conditional logic for downloading the dataproc jar to ensure it only occurs in the appropriate mode.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the run.py file, focusing on the control flow within the Runner class's run method. Key changes include conditional logic adjustments for downloading the dataproc jar based on the self.dataproc flag, streamlined command construction for execution, and preserved error handling assertions related to parallelism and date ranges.

Changes

File	Change Summary
api/py/ai/chronon/repo/run.py	- Updated comments for clarity on jar download - Conditional logic for downloading the jar based on self.dataproc - Streamlined command construction for readability - Preserved assertions and error messages related to execution

Possibly related PRs

• Remove extra download dataproc jar from run.py #193: This PR modifies the same run.py file and specifically addresses the downloading of the Dataproc jar, which is directly related to the changes made in the main PR regarding conditional logic for jar downloading.

Suggested reviewers

• tchow-zlai
• piyush-zlai

Poem

In the code where logic flows,
Conditional paths now clearly show.
Commands align, neat and bright,
Clarity shines, a coding delight! ✨
With every change, our code does sing,
A dance of logic, a joyful thing! 🎶

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 5aad967 and a54731d.

📒 Files selected for processing (1)

• api/py/ai/chronon/repo/run.py (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• api/py/ai/chronon/repo/run.py

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: no_spark_scala_tests

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

LGTM