-
Notifications
You must be signed in to change notification settings - Fork 9
Setup frontend CI #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Setup frontend CI #139
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a809d40
Setup frontend CI
techniq d4d6434
Add `.github/workflows/**` to event path to enable testing workflow (…
techniq 5e21375
Switch back to npm for workflow (until we've added `packageManager` i…
techniq 453ffb7
Skip linting for now (will run `npm run format` in a separate PR and …
techniq dbed6de
Disable unit tests (requires API access)
techniq 19367e5
Comment out all steps requiring API or additional work (ex. run prett…
techniq 2a52387
Scope workflow path to self
techniq a113431
Ignore more build artifacts from lint (pretter) include SvelteKit, Pl…
techniq de8cf80
Enable `npm run check` and `npm run lint` CI steps
techniq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| name: Test Frontend | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'frontend/src/**' | ||
| - '.github/workflows/test_frontend.yaml' | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'frontend/src/**' | ||
| - '.github/workflows/test_frontend.yaml' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| frontend_tests: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./frontend | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| # TODO: Disabled until `test:integration` is ran | ||
| # - name: Install playwright browsers | ||
| # run: npx playwright install --with-deps | ||
|
|
||
| # TODO: Disabled until type errors are fixed (ECharts, etc) | ||
| # - name: Run svelte-check | ||
| # run: npm run check | ||
|
|
||
| # TODO: Disabled until prettier format ran across project | ||
| # - name: Lint project (prettier format and eslint) | ||
| # run: npm run lint | ||
|
|
||
| # TODO: Disabled until API is setup | ||
| # - name: Run unit tests (vitest) | ||
| # run: npm run test:unit | ||
| # env: | ||
| # CI: true | ||
|
|
||
| # TODO: Disabled until API is setup | ||
| # - name: Run integration tests (playwright) | ||
| # run: npm run test:integration | ||
| # env: | ||
| # CI: true | ||
|
|
||
| # TODO: Disabled until `test:integration` is ran | ||
| # - name: Upload playwright report | ||
| # uses: actions/upload-artifact@v4 | ||
| # if: ${{ !cancelled() }} | ||
| # with: | ||
| # name: playwright-report | ||
| # path: playwright-report/ | ||
| # retention-days: 30 | ||
|
|
||
| - name: Build project | ||
| run: npm run build | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable linting step for code quality
The linting step is currently commented out. Linting is crucial for maintaining code quality and consistency. Consider enabling it to catch potential issues early.
Remove the comments to enable linting:
📝 Committable suggestion