Skip to content

Deprecate Invalid config checking#304

Merged
sre-ci-robot merged 1 commit intozilliztech:2.2from
liliu-z:deprecate_invalid_key_check
Dec 14, 2023
Merged

Deprecate Invalid config checking#304
sre-ci-robot merged 1 commit intozilliztech:2.2from
liliu-z:deprecate_invalid_key_check

Conversation

@liliu-z
Copy link
Collaborator

@liliu-z liliu-z commented Dec 14, 2023

/kind improvement

Signed-off-by: Li Liu <li.liu@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot added the ci-passed label Dec 14, 2023
@sre-ci-robot sre-ci-robot merged commit 16c1f7e into zilliztech:2.2 Dec 14, 2023
foxspy added a commit to foxspy/knowhere that referenced this pull request Jan 30, 2024
* Remove omp (zilliztech#276)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* [cherry-pick]Pip3 install in requirements.txt order (zilliztech#303)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>

* Cherry-pick zilliztech#294 zilliztech#298 from main (zilliztech#300)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* Deprecate Invalid config checking (zilliztech#304)

Signed-off-by: Li Liu <li.liu@zilliz.com>

---------

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Signed-off-by: Li Liu <li.liu@zilliz.com>
Co-authored-by: Cai Yudong <yudong.cai@zilliz.com>
Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com>
Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com>
foxspy added a commit to foxspy/knowhere that referenced this pull request Jan 30, 2024
* Remove omp (zilliztech#276)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* [cherry-pick]Pip3 install in requirements.txt order (zilliztech#303)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>

* Cherry-pick zilliztech#294 zilliztech#298 from main (zilliztech#300)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* Deprecate Invalid config checking (zilliztech#304)

Signed-off-by: Li Liu <li.liu@zilliz.com>

* Fix scann range search (zilliztech#316)

Signed-off-by: chasingegg <chao.gao@zilliz.com>

* fix upload failed

Signed-off-by: xianliang <xianliang.li@zilliz.com>

---------

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Signed-off-by: Li Liu <li.liu@zilliz.com>
Signed-off-by: chasingegg <chao.gao@zilliz.com>
Signed-off-by: xianliang <xianliang.li@zilliz.com>
Co-authored-by: Cai Yudong <yudong.cai@zilliz.com>
Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com>
Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com>
Co-authored-by: Gao <chao.gao@zilliz.com>
foxspy added a commit that referenced this pull request Feb 29, 2024
* Remove omp (#276)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* [cherry-pick]Pip3 install in requirements.txt order (#303)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>

* Cherry-pick #294 #298 from main (#300)

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>

* Deprecate Invalid config checking (#304)

Signed-off-by: Li Liu <li.liu@zilliz.com>

* Fix scann range search (#316)

Signed-off-by: chasingegg <chao.gao@zilliz.com>

* Upgrade conan to 1.61.0 (#182) (#347)

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Co-authored-by: Enwei Jiao <enwei.jiao@zilliz.com>

* raft hasrawdata return false

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>

* switch knowhere-test branch (#384)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>

* Ensure topk results for IVF_FLAT_CC (#353) (#383)

Signed-off-by: chasingegg <chao.gao@zilliz.com>

* make sure we rethrow exceptions in async tasks: make sure we do not crash due to uncaught exceptions when we called folly::Future::wait but not trying to get the values; use folly::collect to simplify code (#382)

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>

* [2.2 fix] wrap IVF index train/build calls in lambdas passed to knowhere thread pool, so OMP threads spawned will have low nice values (#379)

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>

* fix diskann async cache generation (#377)

Signed-off-by: xianliang <xianliang.li@zilliz.com>

* fix:miss wait thread tasks finish in diskann. (#380)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>

* Shuffle ids for building hnsw index (#322) (#381)

Signed-off-by: chasingegg <chao.gao@zilliz.com>

* sync knowherer 2.2.4

Signed-off-by: xianliang <xianliang.li@zilliz.com>

---------

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Signed-off-by: Li Liu <li.liu@zilliz.com>
Signed-off-by: chasingegg <chao.gao@zilliz.com>
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Signed-off-by: xianliang <xianliang.li@zilliz.com>
Co-authored-by: Cai Yudong <yudong.cai@zilliz.com>
Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com>
Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com>
Co-authored-by: Gao <chao.gao@zilliz.com>
Co-authored-by: Enwei Jiao <enwei.jiao@zilliz.com>
Co-authored-by: yusheng.ma <yusheng.ma@zilliz.com>
Co-authored-by: Buqian Zheng <zhengbuqian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants