Remove useless prometheus metrics#294
Merged
sre-ci-robot merged 1 commit intozilliztech:mainfrom Dec 13, 2023
Merged
Conversation
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Collaborator
|
/lgtm |
Contributor
Author
|
/kind improvement |
Collaborator
|
/lgtm |
chasingegg
reviewed
Dec 13, 2023
Collaborator
chasingegg
left a comment
chasingegg
left a comment
There was a problem hiding this comment.
why remove search_topk.. it is useful to see if knowhere'search topk vs milvus search topk are the same
cydrain
added a commit
to cydrain/knowhere
that referenced
this pull request
Dec 14, 2023
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
cydrain
added a commit
to cydrain/knowhere
that referenced
this pull request
Dec 14, 2023
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 14, 2023
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
foxspy
added a commit
to foxspy/knowhere
that referenced
this pull request
Jan 30, 2024
* Remove omp (zilliztech#276) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * [cherry-pick]Pip3 install in requirements.txt order (zilliztech#303) Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> * Cherry-pick zilliztech#294 zilliztech#298 from main (zilliztech#300) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * Deprecate Invalid config checking (zilliztech#304) Signed-off-by: Li Liu <li.liu@zilliz.com> --------- Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> Signed-off-by: Li Liu <li.liu@zilliz.com> Co-authored-by: Cai Yudong <yudong.cai@zilliz.com> Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com> Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com>
foxspy
added a commit
to foxspy/knowhere
that referenced
this pull request
Jan 30, 2024
* Remove omp (zilliztech#276) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * [cherry-pick]Pip3 install in requirements.txt order (zilliztech#303) Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> * Cherry-pick zilliztech#294 zilliztech#298 from main (zilliztech#300) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * Deprecate Invalid config checking (zilliztech#304) Signed-off-by: Li Liu <li.liu@zilliz.com> * Fix scann range search (zilliztech#316) Signed-off-by: chasingegg <chao.gao@zilliz.com> * fix upload failed Signed-off-by: xianliang <xianliang.li@zilliz.com> --------- Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> Signed-off-by: Li Liu <li.liu@zilliz.com> Signed-off-by: chasingegg <chao.gao@zilliz.com> Signed-off-by: xianliang <xianliang.li@zilliz.com> Co-authored-by: Cai Yudong <yudong.cai@zilliz.com> Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com> Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com> Co-authored-by: Gao <chao.gao@zilliz.com>
foxspy
added a commit
that referenced
this pull request
Feb 29, 2024
* Remove omp (#276) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * [cherry-pick]Pip3 install in requirements.txt order (#303) Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> * Cherry-pick #294 #298 from main (#300) Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> * Deprecate Invalid config checking (#304) Signed-off-by: Li Liu <li.liu@zilliz.com> * Fix scann range search (#316) Signed-off-by: chasingegg <chao.gao@zilliz.com> * Upgrade conan to 1.61.0 (#182) (#347) Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com> Co-authored-by: Enwei Jiao <enwei.jiao@zilliz.com> * raft hasrawdata return false Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com> * switch knowhere-test branch (#384) Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> * Ensure topk results for IVF_FLAT_CC (#353) (#383) Signed-off-by: chasingegg <chao.gao@zilliz.com> * make sure we rethrow exceptions in async tasks: make sure we do not crash due to uncaught exceptions when we called folly::Future::wait but not trying to get the values; use folly::collect to simplify code (#382) Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com> * [2.2 fix] wrap IVF index train/build calls in lambdas passed to knowhere thread pool, so OMP threads spawned will have low nice values (#379) Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com> * fix diskann async cache generation (#377) Signed-off-by: xianliang <xianliang.li@zilliz.com> * fix:miss wait thread tasks finish in diskann. (#380) Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> * Shuffle ids for building hnsw index (#322) (#381) Signed-off-by: chasingegg <chao.gao@zilliz.com> * sync knowherer 2.2.4 Signed-off-by: xianliang <xianliang.li@zilliz.com> --------- Signed-off-by: Yudong Cai <yudong.cai@zilliz.com> Signed-off-by: cqy123456 <qianya.cheng@zilliz.com> Signed-off-by: Li Liu <li.liu@zilliz.com> Signed-off-by: chasingegg <chao.gao@zilliz.com> Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com> Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com> Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com> Signed-off-by: xianliang <xianliang.li@zilliz.com> Co-authored-by: Cai Yudong <yudong.cai@zilliz.com> Co-authored-by: cqy123456 <39671710+cqy123456@users.noreply.github.com> Co-authored-by: liliu-z <105927039+liliu-z@users.noreply.github.com> Co-authored-by: Gao <chao.gao@zilliz.com> Co-authored-by: Enwei Jiao <enwei.jiao@zilliz.com> Co-authored-by: yusheng.ma <yusheng.ma@zilliz.com> Co-authored-by: Buqian Zheng <zhengbuqian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.