-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different Paulmann manufacturer name #2695
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2695 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 282 282
Lines 8637 8638 +1
=======================================
+ Hits 7506 7507 +1
Misses 1131 1131
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@MattFromGer & @TheJulianJES & @javicalle: If I did no mistake 8382404 does NOT solve #2662 WORKING FIX: #2662 (comment)/config/zha_custom_quirks/paulmann/init.py
/config/zha_custom_quirks/paulmann/fourbtnremote.py
|
@drueppela The fix isn't in HA yet. It'll likely only be in 2023.12.x |
Proposed change
Add support for slightly different Paulmann manufacturer name. Some switches have
Paulmann LichtGmbH
, newer models havePaulmann Licht GmbH
as manufacturer name.Additional information
Fixes #2662
Checklist
pre-commit
checks pass / the code has been formatted using Black