Skip to content

Commit 8a8edd6

Browse files
MattFromGerlgraf
authored andcommitted
Add support for different Paulmann manufacturer name (zigpy#2695)
1 parent 9397aa3 commit 8a8edd6

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

tests/test_paulmann.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
"""Tests for Paulmann quirks."""
22

3+
import pytest
4+
35
import zhaquirks.paulmann.fourbtnremote
46

57

6-
def test_fourbtnremote_signature(assert_signature_matches_quirk):
8+
@pytest.mark.parametrize("manufacturer", ("Paulmann LichtGmbH", "Paulmann Licht GmbH"))
9+
def test_fourbtnremote_signature(assert_signature_matches_quirk, manufacturer):
710
"""Test PaulmannRemote4Btn signature is matched to its quirk."""
811
signature = {
912
"node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4644, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
@@ -39,7 +42,7 @@ def test_fourbtnremote_signature(assert_signature_matches_quirk):
3942
],
4043
},
4144
},
42-
"manufacturer": "Paulmann LichtGmbH",
45+
"manufacturer": manufacturer,
4346
"model": "501.34",
4447
"class": "paulmann.fourbtnremote.PaulmannRemote4Btn",
4548
}

zhaquirks/paulmann/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
"""Paulmann module."""
22

33
PAULMANN = "Paulmann LichtGmbH"
4+
PAULMANN_VARIANT = "Paulmann Licht GmbH"

zhaquirks/paulmann/fourbtnremote.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
PROFILE_ID,
3939
SHORT_PRESS,
4040
)
41-
from zhaquirks.paulmann import PAULMANN
41+
from zhaquirks.paulmann import PAULMANN, PAULMANN_VARIANT
4242

4343

4444
class PaulmannRemote4Btn(CustomDevice):
@@ -49,7 +49,7 @@ class PaulmannRemote4Btn(CustomDevice):
4949
# device_version=0
5050
# input_clusters=[0, 1, 3, 2821, 4096]
5151
# output_clusters=[3, 4, 5, 6, 8, 25, 768, 4096]>
52-
MODELS_INFO: [(PAULMANN, "501.34")],
52+
MODELS_INFO: [(PAULMANN, "501.34"), (PAULMANN_VARIANT, "501.34")],
5353
ENDPOINTS: {
5454
1: {
5555
PROFILE_ID: zha.PROFILE_ID,

0 commit comments

Comments
 (0)