Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XBee: Use named arguments for cluster commands #1902

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Nov 7, 2022

This PR allows to use the new style named params for zha.issue_zigbee_cluster_command service for the XBee quirk as the old style gets deprecated.

Old way:

      service: zha.issue_zigbee_cluster_command
      data:
        ...
        args: Assistant

New way:

      service: zha.issue_zigbee_cluster_command
      data:
        ...
        params:
          data: Assistant

@coveralls
Copy link

coveralls commented Nov 7, 2022

Pull Request Test Coverage Report for Build 3441336388

  • 24 of 24 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 82.888%

Totals Coverage Status
Change from base Build 3400672662: -0.005%
Covered Lines: 6292
Relevant Lines: 7591

💛 - Coveralls

xbee.md Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Base: 82.79% // Head: 82.88% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (8af85c6) compared to base (249ec6d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1902      +/-   ##
==========================================
+ Coverage   82.79%   82.88%   +0.09%     
==========================================
  Files         242      245       +3     
  Lines        7526     7591      +65     
==========================================
+ Hits         6231     6292      +61     
- Misses       1295     1299       +4     
Impacted Files Coverage Δ
zhaquirks/xbee/__init__.py 93.28% <100.00%> (+0.08%) ⬆️
zhaquirks/xiaomi/aqara/cube_aqgl01.py 71.92% <0.00%> (-0.40%) ⬇️
zhaquirks/tuya/ts110e.py 64.44% <0.00%> (ø)
zhaquirks/tuya/__init__.py 72.50% <0.00%> (ø)
zhaquirks/xiaomi/__init__.py 83.79% <0.00%> (ø)
zhaquirks/tuya/ts011f_plug.py 100.00% <0.00%> (ø)
zhaquirks/inovelli/__init__.py 100.00% <0.00%> (ø)
zhaquirks/sinope/thermostat.py 100.00% <0.00%> (ø)
zhaquirks/tuya/mcu/__init__.py 100.00% <0.00%> (ø)
zhaquirks/tuya/ts0601_motion.py 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmulcahey
Copy link
Collaborator

@Shulyaka are you finished w/ this?

@dmulcahey
Copy link
Collaborator

I am going to merge this so it makes it into the release

@dmulcahey dmulcahey merged commit d6bdb39 into zigpy:dev Nov 11, 2022
@Shulyaka
Copy link
Contributor Author

Thanks!

@Shulyaka Shulyaka deleted the xbee_named_arguments branch November 11, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants