Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqara cube fixes #1893

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Aqara cube fixes #1893

merged 2 commits into from
Nov 5, 2022

Conversation

travipross
Copy link
Contributor

Adds support for reporting "deactivated_face" on 90-degree flip events for the aqara cube (as was done for other models of the device in #1271).

Also fixes some typos in movement descriptions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3400337053

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 82.892%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/xiaomi/aqara/cube_aqgl01.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
zhaquirks/xiaomi/aqara/cube_aqgl01.py 1 71.93%
Totals Coverage Status
Change from base Build 3397460325: -0.009%
Covered Lines: 6299
Relevant Lines: 7599

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Base: 82.90% // Head: 82.89% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (eebfd8f) compared to base (d84e71f).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1893      +/-   ##
==========================================
- Coverage   82.90%   82.89%   -0.01%     
==========================================
  Files         245      245              
  Lines        7597     7599       +2     
==========================================
+ Hits         6298     6299       +1     
- Misses       1299     1300       +1     
Impacted Files Coverage Δ
zhaquirks/xiaomi/aqara/cube.py 72.72% <ø> (ø)
zhaquirks/xiaomi/aqara/cube_aqgl01.py 71.92% <50.00%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmulcahey dmulcahey merged commit c2de1b2 into zigpy:dev Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants