Skip to content

Add more support for aqara magic cube #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Conversation

tribela
Copy link
Contributor

@tribela tribela commented Jan 9, 2022

  • Add "from face" attribute when flip 90 degrees (eg: flip from face 2 to face 3)
  • Add wake up event (when pick up the device while it was standing still)

- from face when flip
- wake up event
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #1271 (1507bb1) into dev (b0bbbfb) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1271      +/-   ##
==========================================
+ Coverage   80.27%   80.30%   +0.03%     
==========================================
  Files         207      207              
  Lines        5693     5707      +14     
==========================================
+ Hits         4570     4583      +13     
- Misses       1123     1124       +1     
Impacted Files Coverage Δ
zhaquirks/xiaomi/aqara/cube.py 72.72% <80.00%> (+0.34%) ⬆️
zhaquirks/sinope/light.py 100.00% <0.00%> (ø)
zhaquirks/tuya/__init__.py 76.60% <0.00%> (ø)
zhaquirks/sinope/thermostat.py 100.00% <0.00%> (ø)
zhaquirks/tuya/ts0601_cover.py 100.00% <0.00%> (ø)
zhaquirks/xiaomi/mija/smoke.py 90.00% <0.00%> (ø)
zhaquirks/tuya/ts0601_trv_sas.py 53.94% <0.00%> (ø)
zhaquirks/xiaomi/aqara/wleak_aq1.py 100.00% <0.00%> (ø)
zhaquirks/xiaomi/aqara/magnet_aq2.py 85.71% <0.00%> (ø)
zhaquirks/xiaomi/aqara/motion_aq2.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bbbfb...1507bb1. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 9, 2022

Pull Request Test Coverage Report for Build 1695574086

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 151 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 80.305%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/xiaomi/aqara/cube.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
zhaquirks/xiaomi/aqara/cube.py 1 72.73%
zhaquirks/xiaomi/aqara/magnet_aq2.py 1 85.71%
zhaquirks/xiaomi/mija/smoke.py 1 90.0%
zhaquirks/xiaomi/aqara/sensor_switch_aq3.py 3 76.92%
zhaquirks/xiaomi/aqara/remote_b186acn01.py 4 75.0%
zhaquirks/xiaomi/aqara/remote_b286acn01.py 4 76.19%
zhaquirks/xiaomi/aqara/sensor_swit.py 4 71.88%
zhaquirks/xiaomi/aqara/vibration_aq1.py 8 64.29%
zhaquirks/xiaomi/aqara/cube_aqgl01.py 14 72.32%
zhaquirks/xiaomi/init.py 47 83.5%
Totals Coverage Status
Change from base Build 1662941388: 0.03%
Covered Lines: 4583
Relevant Lines: 5707

💛 - Coveralls

@dmulcahey dmulcahey merged commit 51efc4c into zigpy:dev Jan 17, 2022
@tribela tribela deleted the fix-aqara-cube branch January 19, 2022 03:11
@travipross travipross mentioned this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants